[15.0][MIG] base_recurrence: Migration to 15.0 #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyasProgrammer
force-pushed
the
15.0-mig-base_recurrence
branch
from
fc050bc
to
2a13213
Compare
|
@rousseldenis good migration? :) |
geomer198
reviewed
Aug 3, 2023
| else: | ||
| raise NotImplementedError() | ||
|
|
||
| # HELPER FUNCTIONS # |
There was a problem hiding this comment.
I think need add api.model decorator for all HELPER FUNCTIONS witch start with _recurring.
There was a problem hiding this comment.
that is true! I missed it in my review.
ilyasProgrammer
force-pushed
the
15.0-mig-base_recurrence
branch
from
2a13213
to
b202c62
Compare
|
@geomer198 @rousseldenis good for you? |
rousseldenis
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
Sorry. On holidays :-) @ilyasProgrammer thanks for your interest in this module
|
/ocabot migration base_recurrence |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
rvalyi
approved these changes
Aug 4, 2023
|
Congratulations, your PR was merged at 3f0e642. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.