Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] base_tier_validation: multiple comment with approve_sequence_bypass #699

Merged
merged 1 commit into from
Aug 9, 2023
Merged

[14.0][FIX] base_tier_validation: multiple comment with approve_sequence_bypass #699

merged 1 commit into from
Aug 9, 2023

Conversation

mathben
Copy link
Contributor

@mathben mathben commented Aug 2, 2023 

[FIX] base_tier_validation: multiple comment with approve_sequence_bypass

- when option approve_sequence_bypass is enable and comments option with
sequence, the user add a comment and all level approbation add this
comment.
This code add comment only for appropriate tier validation

@mathben
[FIX] base_tier_validation: multiple comment with approve_sequence_by…
f139adc 
…pass

- when option approve_sequence_bypass is enable and comments option with
sequence, the user add a comment and all level approbation add this
comment.
This code add comment only for appropriate tier validation.
@OCA-git-bot
Copy link
Contributor

Hi @LoisRForgeFlow,
some modules you are maintaining are being modified, check this out!

@LoisRForgeFlow
Copy link
Contributor

@kittiu I think you added this feature and use it, could you check this change? Thanks!

kittiu
kittiu approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@kittiu kittiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is valid. 👍

LoisRForgeFlow
LoisRForgeFlow approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-699-by-LoisRForgeFlow-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 420c764 into OCA:14.0 Aug 9, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1088606. Thanks a lot for contributing to OCA. ❤️

@mathben mathben deleted the 14.0_fix_tier_approbation_comment_approve_sequence_bypass branch August 9, 2023 15:03
This was referenced Jan 11, 2024
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittiu kittiu kittiu approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mathben @OCA-git-bot @LoisRForgeFlow @kittiu