Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] base_tier_validation: compute validation flag dynamically #694

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Jul 12, 2023

with this the validation button shows immediately on a form and not only after save

@astirpe finally I find time to work on this again. I'm a bit at a loss as to why this doesn't work for you, it does on runboat though, even with just domain [('move_type', '=', 'in_invoice')]:

image

image

@OCA-git-bot
Copy link
Contributor

Hi @LoisRForgeFlow,
some modules you are maintaining are being modified, check this out!

@astirpe
Copy link
Member

astirpe commented Jul 13, 2023

Tested in Runboat and it works perfectly!
Locally I still have the same problem, so I'm probably doing something wrong.

@hbrunn
Copy link
Member Author

hbrunn commented Jul 13, 2023

do you reload your webclient after you've edited the domain? the onchange triggers are part of the form caching.
and i'm still not 100% convinced i do the registry updating right, so safest thing to do would be restart odoo + f5

@astirpe
Copy link
Member

astirpe commented Jul 13, 2023

Yes, I tried many times with restart reload, refresh, etc.. but this is the behavior:

Before saving
image

After saving
image

@hbrunn
Copy link
Member Author

hbrunn commented Jul 15, 2023

do you possibly have a very old checkout of odoo?

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 31, 2023
@github-actions github-actions bot closed this Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants