[16.0][IMP] base_custom_filter: add search feature #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ForgeFlow, @AshishHirapara, |
AungKoKoLin1997
force-pushed
the
16.0-imp-base_custom_filter
branch
from
9781791
to
9bf73f1
Compare
AungKoKoLin1997
force-pushed
the
16.0-imp-base_custom_filter
branch
from
9bf73f1
to
c8199be
Compare
AungKoKoLin1997
changed the title
yostashiro
approved these changes
Jun 16, 2023
yostashiro
suggested changes
Jun 16, 2023
| <field | ||
| name="group_id" | ||
| domain="[('model_id', '=', model_id), ('type', '=', type)]" | ||
| context="{'default_model_id': model_id, 'default_type': type}" | ||
| attrs="{'invisible': [('type', '=', 'favorite')]}" | ||
| attrs="{'invisible': [('type', 'in', ['favorite', 'search'])]}" | ||
| /> | ||
| </field> | ||
| <field name="domain" position="attributes"> |
There was a problem hiding this comment.
Can we hide domain field for the search type as well? The widget doesn't work in the way it should unless we tweak a bit so that it looks at the model of the selected field, and this attribute is rarely used anyway.
|
|
||
| * Search Field (``name``) | ||
| * Filter Domain (``filter_domain``) | ||
| * Domain (``domain``) |
There was a problem hiding this comment.
Suggested change
| * Domain (``domain``) |
AungKoKoLin1997
force-pushed
the
16.0-imp-base_custom_filter
branch
from
1b70601
to
77b4d60
Compare
|
@OCA/tools-maintainers Can we please get this PR merged? |
AungKoKoLin1997
force-pushed
the
16.0-imp-base_custom_filter
branch
from
77b4d60
to
217b99e
Compare
AungKoKoLin1997
force-pushed
the
16.0-imp-base_custom_filter
branch
from
217b99e
to
14d3372
Compare
|
/ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 3b04863. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates a search feature into custom filters, allowing users to search using fields within a model's view. Additionally, it introduces a group_ids field to manage the visibility of custom filters for different users.
@qrtl