-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][ADD] server_action_merge #625
Conversation
[("orm", "ORM"), ("sql", "SQL")], default="orm", string="Merge method" | ||
) | ||
merge_handling = fields.Selection( | ||
[("delete", "Delete"), ("deactivate", "Deactivate"), ("none", "Do nothing")], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what will happen if the "none" option is selected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, nothing ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense ?
we could :
- remove that option
- remove the default (default=False)
- by view, set merge_handling required, if state==merge
- by constrains, forbid state==merge and merge_handling==False
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added a help text for this. I think 'delete' is a good default, that's how I'd expect a merge operation to work in general. But there might be cases where you'd like to keep the merged records, and if there's no 'active' field, doing nothing is the only option, right?
d6844f1
to
8caebd8
Compare
2cf4974
to
0298e46
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
This module allows users to merge records of arbitrary models.
Configuration
To configure this module, you need to:
Merge
(fieldAction To Do
)Create Contextual Action
to make the action accessible for usersUsage
To use this module, you need to:
Merge
Technically, this is a UI for https://github.com/OCA/openupgradelib/blob/master/openupgradelib/openupgrade_merge_records.py#L916