[14.0][ADD] web_tree_customized_field_list #623

ilyasProgrammer · 2023-03-22T17:35:23Z

No description provided.

elvise · 2023-09-27T07:41:39Z

@ilyasProgrammer can you rebase ?

elvise · 2023-09-27T08:02:07Z

/ocabot rebase

OCA-git-bot · 2023-09-27T08:02:20Z

Sorry @elvise you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

ilyasProgrammer · 2023-09-27T08:10:01Z

@elvise done

elvise · 2023-12-28T18:51:10Z

@ilyasProgrammer please rebase :)

francesco-ooops

Functional ok!

Often a customer asks to add a field to tree view, and this requires dev time. This module allows functionals to be independent on adding fields to tree view.

geomer198

Could you please fix code by my comments.

customized_list_view/models/custom_list.py

customized_list_view/tests/test_customized_list_view.py

ilyasProgrammer · 2024-02-12T04:56:34Z

@geomer198 Thanks for the review. Updated according to your suggestions.

aleuffre

Code review, only a few minor remarks.

However, I should point out that the customizations do not survive an upgrade. In other words, when any module is upgraded, the views of that module are reverted back to what is written in the XML file, and it would be necessary to press "Apply Changes" again to make them appear again (Tested on runboat)

customized_list_view/models/custom_list.py

customized_list_view/security/ir.model.access.csv

ilyasProgrammer · 2024-02-15T06:23:19Z

Code review, only a few minor remarks.

However, I should point out that the customizations do not survive an upgrade. In other words, when any module is upgraded, the views of that module are reverted back to what is written in the XML file, and it would be necessary to press "Apply Changes" again to make them appear again (Tested on runboat)

Thats right. Updated description and added roadmap.

customized_list_view/models/custom_list.py

aleuffre

Approved with the above caveat that it may be very counterintuitive to use.

aleuffre · 2024-02-23T11:43:29Z

customized_list_view/models/ir_module.py

+class Module(models.Model):
+    _inherit = "ir.module.module"
+
+    def _button_immediate_function(self, function):


praise this is an elegant way of making the changes persistent

thought: not all changes may be applied. at any given time. I'd say we could either add the active field to the custom.list.view model, or another boolean field to keep track of which changes need to be applied and which ones should not.

aleuffre · 2024-03-25T14:59:46Z

Code review LGTM

geomer198

Could you check my review?

customized_list_view/models/custom_list.py

geomer198 · 2024-04-01T21:22:36Z

customized_list_view/models/ir_module.py

+    def _button_immediate_function(self, function):
+        res = super(Module, self)._button_immediate_function(function)
+        views_mods = self.env["custom.list.view"].search([])
+        for vm in views_mods:


This solution is not optimal.
Please change this implementation without 2 cycles. If you want remove all 'custom.list.view.line' records without field_id value, you can use search for this. I think it's faster then you solution.

customized_list_view/tests/test_customized_list_view.py

geomer198

Please, add little fix.

geomer198 · 2024-04-05T16:04:53Z

customized_list_view/models/custom_list.py

+    active = fields.Boolean(default=True)
+    name = fields.Char(required=True)
+    model_id = fields.Many2one("ir.model", required=True, ondelete="cascade")
+    model_name = fields.Char(related="model_id.model", store=True)


For what you use store here?

To avoid recompute.

geomer198 · 2024-04-05T16:08:29Z

customized_list_view/tests/test_customized_list_view.py

+        cls.users_model = cls.env["ir.model"]._get("res.users")
+        cls.view_users_tree = cls.env.ref("base.view_users_tree")
+
+    def test_all_customized_list_view(self):


Could you add doc string for this test method, which describe what this method do?

The method is for tests. There is comment for each subtest and message for each assert. It is sufficient.

geomer198

LGTM!

francesco-ooops · 2024-04-19T13:37:43Z

@pedrobaeza could you merge this one? thanks!

pedrobaeza · 2024-04-19T13:54:56Z

Being a modification of the web client, it should be prefixed with web_ IMO. A name can be web_tree_customized_field_list.

francesco-ooops · 2024-04-19T13:57:25Z

@pedrobaeza should it be in this repo or in OCA/web in your opinion?

pedrobaeza · 2024-04-19T13:59:22Z

Good question... Let's keep it here as is less crowded.

OCA-git-bot · 2024-04-29T15:00:05Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

francesco-ooops

LGTM

@pedrobaeza shall we go?

pedrobaeza · 2024-05-02T09:48:44Z

/ocabot merge nobump

OCA-git-bot · 2024-05-02T09:49:02Z

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-623-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-05-02T09:56:49Z

Congratulations, your PR was merged at 7054737. Thanks a lot for contributing to OCA. ❤️

ilyasProgrammer force-pushed the 14.0-customized_list_view branch from c3a40cc to eab9c76 Compare September 27, 2023 08:09

ilyasProgrammer force-pushed the 14.0-customized_list_view branch from a6b3e20 to 8d5aae7 Compare February 1, 2024 06:35

ilyasProgrammer marked this pull request as ready for review February 7, 2024 14:15

ilyasProgrammer force-pushed the 14.0-customized_list_view branch 6 times, most recently from b5630bc to 131f3e1 Compare February 9, 2024 08:33

francesco-ooops approved these changes Feb 9, 2024

View reviewed changes

geomer198 suggested changes Feb 9, 2024

View reviewed changes

ilyasProgrammer force-pushed the 14.0-customized_list_view branch from 131f3e1 to 6d4a936 Compare February 12, 2024 04:55

ilyasProgrammer requested a review from geomer198 February 12, 2024 04:56

ilyasProgrammer force-pushed the 14.0-customized_list_view branch from 6d4a936 to 253aa8d Compare February 12, 2024 05:02

aleuffre reviewed Feb 14, 2024

View reviewed changes

customized_list_view/models/custom_list.py Outdated Show resolved Hide resolved

customized_list_view/security/ir.model.access.csv Outdated Show resolved Hide resolved

ilyasProgrammer force-pushed the 14.0-customized_list_view branch from 253aa8d to 121a7f0 Compare February 15, 2024 06:22

ilyasProgrammer requested a review from aleuffre February 15, 2024 06:24

aleuffre reviewed Feb 20, 2024

View reviewed changes

customized_list_view/models/custom_list.py Outdated Show resolved Hide resolved

aleuffre approved these changes Feb 20, 2024

View reviewed changes

ilyasProgrammer force-pushed the 14.0-customized_list_view branch from 121a7f0 to f8e89f8 Compare February 20, 2024 10:18

aleuffre approved these changes Feb 21, 2024

View reviewed changes

aleuffre reviewed Feb 23, 2024

View reviewed changes

ilyasProgrammer force-pushed the 14.0-customized_list_view branch from 4b4725d to 5da2f83 Compare March 8, 2024 05:03

aleuffre approved these changes Mar 25, 2024

View reviewed changes

geomer198 suggested changes Apr 1, 2024

View reviewed changes

ilyasProgrammer force-pushed the 14.0-customized_list_view branch from 5da2f83 to c0bf56a Compare April 3, 2024 06:43

ilyasProgrammer requested a review from geomer198 April 3, 2024 06:43

ilyasProgrammer force-pushed the 14.0-customized_list_view branch 2 times, most recently from ee8a1b8 to 7b0eb28 Compare April 5, 2024 11:00

geomer198 suggested changes Apr 5, 2024

View reviewed changes

geomer198 approved these changes Apr 5, 2024

View reviewed changes

OCA-git-bot added the approved label Apr 5, 2024

pedrobaeza added this to the 14.0 milestone Apr 19, 2024

ilyasProgrammer force-pushed the 14.0-customized_list_view branch from 7b0eb28 to c7cba10 Compare April 22, 2024 07:17

ilyasProgrammer changed the title ~~[14.0][ADD] customized_list_view~~ [14.0][ADD] web_tree_customized_field_list Apr 22, 2024

[ADD] web_tree_customized_field_list

fdf71f6

ilyasProgrammer force-pushed the 14.0-customized_list_view branch from c7cba10 to fdf71f6 Compare April 22, 2024 07:18

ilyasProgrammer requested a review from francesco-ooops April 22, 2024 07:18

OCA-git-bot added the ready to merge label Apr 29, 2024

francesco-ooops approved these changes May 2, 2024

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label May 2, 2024

OCA-git-bot merged commit e8e0075 into OCA:14.0 May 2, 2024
5 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels May 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][ADD] web_tree_customized_field_list #623

[14.0][ADD] web_tree_customized_field_list #623

ilyasProgrammer commented Mar 22, 2023 •

edited

Loading

elvise commented Sep 27, 2023

elvise commented Sep 27, 2023

OCA-git-bot commented Sep 27, 2023

ilyasProgrammer commented Sep 27, 2023

elvise commented Dec 28, 2023

francesco-ooops left a comment

geomer198 left a comment

ilyasProgrammer commented Feb 12, 2024

aleuffre left a comment

ilyasProgrammer commented Feb 15, 2024 •

edited

Loading

aleuffre left a comment

aleuffre Feb 23, 2024

aleuffre commented Mar 25, 2024

geomer198 left a comment

geomer198 Apr 1, 2024

geomer198 left a comment

geomer198 Apr 5, 2024

ilyasProgrammer Apr 5, 2024

geomer198 Apr 5, 2024

ilyasProgrammer Apr 5, 2024

geomer198 left a comment

francesco-ooops commented Apr 19, 2024

pedrobaeza commented Apr 19, 2024

francesco-ooops commented Apr 19, 2024

pedrobaeza commented Apr 19, 2024

OCA-git-bot commented Apr 29, 2024

francesco-ooops left a comment

pedrobaeza commented May 2, 2024

OCA-git-bot commented May 2, 2024

OCA-git-bot commented May 2, 2024

[14.0][ADD] web_tree_customized_field_list #623

[14.0][ADD] web_tree_customized_field_list #623

Conversation

ilyasProgrammer commented Mar 22, 2023 • edited Loading

elvise commented Sep 27, 2023

elvise commented Sep 27, 2023

OCA-git-bot commented Sep 27, 2023

ilyasProgrammer commented Sep 27, 2023

elvise commented Dec 28, 2023

francesco-ooops left a comment

Choose a reason for hiding this comment

geomer198 left a comment

Choose a reason for hiding this comment

ilyasProgrammer commented Feb 12, 2024

aleuffre left a comment

Choose a reason for hiding this comment

ilyasProgrammer commented Feb 15, 2024 • edited Loading

aleuffre left a comment

Choose a reason for hiding this comment

aleuffre Feb 23, 2024

Choose a reason for hiding this comment

aleuffre commented Mar 25, 2024

geomer198 left a comment

Choose a reason for hiding this comment

geomer198 Apr 1, 2024

Choose a reason for hiding this comment

geomer198 left a comment

Choose a reason for hiding this comment

geomer198 Apr 5, 2024

Choose a reason for hiding this comment

ilyasProgrammer Apr 5, 2024

Choose a reason for hiding this comment

geomer198 Apr 5, 2024

Choose a reason for hiding this comment

ilyasProgrammer Apr 5, 2024

Choose a reason for hiding this comment

geomer198 left a comment

Choose a reason for hiding this comment

francesco-ooops commented Apr 19, 2024

pedrobaeza commented Apr 19, 2024

francesco-ooops commented Apr 19, 2024

pedrobaeza commented Apr 19, 2024

OCA-git-bot commented Apr 29, 2024

francesco-ooops left a comment

Choose a reason for hiding this comment

pedrobaeza commented May 2, 2024

OCA-git-bot commented May 2, 2024

OCA-git-bot commented May 2, 2024

ilyasProgrammer commented Mar 22, 2023 •

edited

Loading

ilyasProgrammer commented Feb 15, 2024 •

edited

Loading