[FIX] base_substate: send email template on substate

base_substate/models/base_substate_mixin.py

@@ -28,23 +28,6 @@ def check_substate_id_value(self):
                     }
                 )
 
-    def _track_template(self, tracking):
-        res = super()._track_template(tracking)
-        first_rec = self[0]
-        changes, tracking_value_ids = tracking[first_rec.id]
-        if "substate_id" in changes and first_rec.substate_id.mail_template_id:
-            res["substate_id"] = (
-                first_rec.substate_id.mail_template_id,
-                {
-                    "auto_delete_message": True,
-                    "subtype_id": self.env["ir.model.data"].xmlid_to_res_id(
-                        "mail.mt_note"
-                    ),
-                    "notif_layout": "mail.mail_notification_light",
-                },
-            )
-        return res
-
     def _get_default_substate_id(self, state_val=False):
         """Gives default substate_id"""
         search_domain = self._get_default_substate_domain(state_val)
@@ -116,6 +99,19 @@ def _update_before_write_create(self, values):
         if values.get(state_field) and not values.get("substate_id"):
             state_val = values.get(state_field)
             values["substate_id"] = self._get_default_substate_id(state_val)
+        # Send mail if substate has mail template
+        if values.get("substate_id"):
+            substate = self.env["base.substate"].browse(values["substate_id"])
+            if (
+                hasattr(self, "message_post_with_template")
+                and substate.mail_template_id
+            ):
+                self.message_post_with_template(
+                    substate.mail_template_id.id,
+                    subtype_id=self.env["ir.model.data"]._xmlid_to_res_id(
+                        "mail.mt_note"
+                    ),
+                )
         return values
 
     def write(self, values):

base_substate/tests/sale_test.py

@@ -6,8 +6,8 @@
 
 
 class SaleTest(models.Model, TestMixin):
-    _inherit = "base.substate.mixin"
     _name = "base.substate.test.sale"
+    _inherit = ["base.substate.mixin", "mail.thread"]
     _description = "Base substate Test Model"
 
     name = fields.Char(required=True)

base_substate/tests/test_base_substate.py

@@ -17,6 +17,14 @@ def setUpClass(cls):
         cls.substate_test_sale = cls.env["base.substate.test.sale"]
         cls.substate_test_sale_line = cls.env["base.substate.test.sale.line"]
 
+        cls.mail_template = cls.env["mail.template"].create(
+            {
+                "name": "Waiting for legal documents",
+                "model_id": cls.substate_test_sale.id,
+                "subject": "Test Email Substate",
+            }
+        )
+
         cls.base_substate = cls.env["base.substate.mixin"]
         cls.substate_type = cls.env["base.substate.type"]
 
@@ -68,6 +76,7 @@ def setUpClass(cls):
                 "name": "Waiting for legal documents",
                 "sequence": 2,
                 "target_state_value_id": cls.substate_val_sale.id,
+                "mail_template_id": cls.mail_template.id,
             }
         )
 
@@ -106,12 +115,10 @@ def test_sale_order_substate(self):
         )
         self.assertTrue(so_test1.state == "draft")
         self.assertTrue(so_test1.substate_id == self.substate_under_negotiation)
-
-        # Test that validation of sale order change substate_id
+        # Test that validation of sale order change substate_id and send email
         so_test1.button_confirm()
         self.assertTrue(so_test1.state == "sale")
         self.assertTrue(so_test1.substate_id == self.substate_wait_docs)
-
         # Test that substate_id is set to false if
         # there is not substate corresponding to state
         so_test1.button_cancel()