[16.0][ADD] attachment_log #3161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geomer198
force-pushed
the
16.0-t4242-attachment-log-add
branch
from
9b18974 to
fc0cd0a
Compare
hoangtrann
suggested changes
Jan 11, 2025
| message = record.message_post( | ||
| body=Markup( | ||
| _( | ||
| "User <b>%(username)s</b> is attached a new file: <i>%(filename)s</i>" |
There was a problem hiding this comment.
Suggested change
| "User <b>%(username)s</b> is attached a new file: <i>%(filename)s</i>" | |
| "<b>%(username)s</b> attached a file: <i>%(filename)s</i>" |
There was a problem hiding this comment.
It would then show as Mitchell Admin attached a file: Invoice.pdf
ivs-cetmix
suggested changes
Jan 11, 2025
There was a problem hiding this comment.
Here are my concerns: why should we post a message for every attachment added?
What if an incoming email arrives with 10+ attachments in it? It will result in 10+ messages trashing the record chatter.
You can simply show name of the user who added attachment together with the creation date. That is.
| "website": "https://github.com/OCA/server-tools", | ||
| "license": "AGPL-3", | ||
| "category": "Generic Modules", | ||
| "depends": ["base", "mail"], |
There was a problem hiding this comment.
You don't need to depend on base because mail already depends on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module adds the following features for attachments: