[16.0][UPD][FIX] tracking_manager: specific O2M fields notify #3140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some case, we may have some unconventionals O2M like on ir.attachment. The O2M relation is done on res_id value. This commit take them in consideration and avoid a traceback
|
Hi @sebastienbeau, @Kev-Roche, |
sbejaoui
approved these changes
Dec 10, 2024
AnizR
approved these changes
Jan 24, 2025
|
@rousseldenis Do you have super-power here? 💪 😎 |
rvalyi
approved these changes
Jan 24, 2025
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 7e59fd2. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some case, we may have some unconventionals O2M like on
ir.attachment. The O2M relation is done onres_idvalue. This commit take them in consideration and avoid a traceback.How to reproduce:
Just add a dynamic track on attachment_ids (example on
account.move).Then add an attachment on the
account.move: you should see a new message into the chatter (that works perfectly)Finally, remove this attachment: without this PR, you should see a traceback into logs. But with this PR, you should see a new message (about the unlink) in the chatter.