connector_search_engine: improve state update wiz #189
+28
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bealdav
approved these changes
Feb 26, 2024
simahawk
commented
Feb 26, 2024
simahawk
force-pushed
the
16-recompute-now
branch
2 times, most recently
from
bcfc380
to
2d391aa
Compare
cyrilmanuel
approved these changes
Mar 26, 2024
_jobify_batch_recompute and batch_recompute now accept a binding_ids param to force the records to be computed.
simahawk
force-pushed
the
16-recompute-now
branch
from
2d391aa
to
81f8e3c
Compare
|
Hi @lmignon is it good for you ? |
lmignon
reviewed
Apr 5, 2024
| @@ -216,12 +216,14 @@ def _jobify_batch_sync(self, force_export: bool = False) -> None: | |||
| description=description, identity_key=identity_exact | |||
| ).batch_sync(force_export) | |||
|
|
|||
| def _jobify_batch_recompute(self, force_export: bool = False) -> None: | |||
| def _jobify_batch_recompute( | |||
| self, force_export: bool = False, binding_ids: list | None = None | |||
There was a problem hiding this comment.
Suggested change
| self, force_export: bool = False, binding_ids: list | None = None | |
| self, force_export: bool = False, binding_ids: list[int] | None = None |
| @@ -256,11 +258,16 @@ def _get_domain_for_recomputing_binding(self, force_export: bool = False) -> lis | |||
| states.append("recomputing") | |||
| return [("index_id", "=", self.id), ("state", "in", states)] | |||
|
|
|||
| def batch_recompute(self, force_export: bool = False) -> None: | |||
| def batch_recompute( | |||
| self, force_export: bool = False, binding_ids: list | None = None | |||
There was a problem hiding this comment.
Suggested change
| self, force_export: bool = False, binding_ids: list | None = None | |
| self, force_export: bool = False, binding_ids: list[int] | None = None |
sbidoul
reviewed
Apr 5, 2024
| @@ -256,11 +258,16 @@ def _get_domain_for_recomputing_binding(self, force_export: bool = False) -> lis | |||
| states.append("recomputing") | |||
| return [("index_id", "=", self.id), ("state", "in", states)] | |||
|
|
|||
| def batch_recompute(self, force_export: bool = False) -> None: | |||
| def batch_recompute( | |||
| self, force_export: bool = False, binding_ids: list | None = None | |||
There was a problem hiding this comment.
What do you think about doing another method? (batch_recompute_bindings_ids?), and factoring out the common part. Less if's is good, in general.
sbidoul
reviewed
Apr 5, 2024
| self.ensure_one() | ||
| description = _("Prepare a batch recompute of index '%s'") % self.name | ||
| self.with_delay( | ||
| description=description, identity_key=identity_exact | ||
| ).batch_recompute(force_export) | ||
| ).batch_recompute(force_export, binding_ids=binding_ids) |
There was a problem hiding this comment.
Strictly speaking this job description is now inaccurate because it is now a partial recompute? So maybe this method should be split too?
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
lmignon
added
no stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to schedule jobs right away instead of waiting for the cron to pass by.