Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] fastapi_auth_jwt, fastapi_auth_jwt_demo #347

Merged
merged 4 commits into from
Jun 26, 2023
Merged

[16.0][ADD] fastapi_auth_jwt, fastapi_auth_jwt_demo #347

merged 4 commits into from
Jun 26, 2023

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Jun 15, 2023 •
edited
Loading

The fastapi_auth_jwt module provides FastAPI dependencies to allow authentication with auth_jwt.

See USAGE.rstfor more information.

Sill draft as I have some doubts about the best structure of the dependencies.

  • Should they be classes where the JWT validator name can be configured or should we rely exclusively on FastAPI depends overrides to select the JWT validator. => classes remain but the public API is the functions
  • Not sure what to do about the odoo environment dependency... => added auth_jwt_authenticated_odoo_env
  • depends on [16.0] auth_jwt: add cookie mode server-auth#520

@OCA-git-bot
Copy link
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@sbidoul sbidoul force-pushed the 16.0-fastapi_auth_jwt branch from 122c47d to 5194c59 Compare June 15, 2023 16:50
@sbidoul sbidoul mentioned this pull request Jun 16, 2023
Closed
@sbidoul sbidoul force-pushed the 16.0-fastapi_auth_jwt branch 2 times, most recently from 8657a25 to b006c89 Compare June 16, 2023 15:56
@sbidoul sbidoul marked this pull request as ready for review June 16, 2023 16:02
@sbidoul sbidoul force-pushed the 16.0-fastapi_auth_jwt branch from 1f53221 to 89513b2 Compare June 19, 2023 13:02
@sbidoul sbidoul force-pushed the 16.0-fastapi_auth_jwt branch 3 times, most recently from ab7a012 to 7df3ff7 Compare June 19, 2023 16:21
@sbidoul
Copy link
Member Author

sbidoul commented Jun 19, 2023

🍏 😅

@sbidoul sbidoul force-pushed the 16.0-fastapi_auth_jwt branch from 09bae3c to 16aa6eb Compare June 23, 2023 15:14
@sbidoul sbidoul mentioned this pull request Jun 20, 2023
Merged
2 tasks
lmignon
lmignon approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Codre review and basic functional tests)

@sbidoul
Copy link
Member Author

sbidoul commented Jun 26, 2023

Ok, let's go with this.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-347-by-sbidoul-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 48c1762 into OCA:16.0 Jun 26, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b03d3b5. Thanks a lot for contributing to OCA. ❤️

@sbidoul sbidoul mentioned this pull request Jun 27, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmignon lmignon lmignon approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbidoul @OCA-git-bot @lmignon