Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][IMP] Make default subchannel capacity configurable. #698

Draft
wants to merge 1 commit into
base: 15.0
Choose a base branch
from

Conversation

amh-mw
Copy link
Contributor

@amh-mw amh-mw commented Oct 14, 2024

Either ODOO_QUEUE_JOB_DEFAULT_SUBCHANNEL_CAPACITY may be set as an environment variable, or default_subchannel_capacity may be set in the [queue_job] config file stanza.

@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@amh-mw
Copy link
Contributor Author

amh-mw commented Oct 14, 2024

My own use case is that I run multi-company odoo with an environment like ODOO_QUEUE_JOB_CHANNELS=root:8,single:1. The single channel is for problem children that tend to generate an excess of SerializationFailure if executed in parallel. I've recently determined that those SerializationFailure are company-specific, so a channel per company would improve parallelism.

Per @sbidoul in OCA Discord

Undeclared channels are auto created at runtime, but with an unlimited capacity.

This setting allows me to limit the capacity of auto-created channels.

@amh-mw amh-mw changed the title [IMP] Make default subchannel capacity configurable. [15.0][IMP] Make default subchannel capacity configurable. Oct 14, 2024
@amh-mw amh-mw force-pushed the 15.0-default_subchannel_capacity branch 2 times, most recently from 484bac4 to 50e748b Compare October 14, 2024 19:12
Either ODOO_QUEUE_JOB_DEFAULT_SUBCHANNEL_CAPACITY may be set as
an environment variable, or default_subchannel_capacity may be set
in the [queue_job] config file stanza.
@amh-mw amh-mw force-pushed the 15.0-default_subchannel_capacity branch from 50e748b to ee6389b Compare October 14, 2024 19:26
@amh-mw amh-mw marked this pull request as ready for review October 14, 2024 19:36
@sbidoul
Copy link
Member

sbidoul commented Oct 18, 2024

Thanks for addressing this @amh-mw

I would have a preference for configuring this in the parent channel, instead of globally.
Like this is done, for instance for the throttle config.

@amh-mw
Copy link
Contributor Author

amh-mw commented Oct 22, 2024

I would have a preference for configuring this in the parent channel, instead of globally. Like this is done, for instance for the throttle config.

Understood. I will unfortunately not have time to circle back around to that request until next year. Would it be possible to mark this issuenostale?

@sbidoul
Copy link
Member

sbidoul commented Oct 22, 2024

@amh-mw Count on me to repoen it if the stale bot closes it. Can you set it Draft? [done]

@sbidoul sbidoul marked this pull request as draft October 22, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants