Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][FIX] Refactor stop signal handling in QueueJobRunner #647

Open
wants to merge 25 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][FIX] Refactor stop signal handling in QueueJobRunner #647

wants to merge 25 commits into from

Commits on May 7, 2024

  1. Refactor stop signal handling in QueueJobRunner 

    This commit refactors the stop signal handling in the `QueueJobRunner` class. Instead of using a pipe, it now uses a socket pair to initialize the stop signals. This change improves the code readability and ensures compatibility with Windows by manually creating a socket pair when the `socketpair` function is not available.
    @Maralai
    Maralai committed May 7, 2024
    Configuration menu
    Copy the full SHA
    dc7e661 View commit details
    Browse the repository at this point in the history

  2. Merge branch '17.0' of https://github.com/OCA/queue into 17.0

    @Maralai
    Maralai committed May 7, 2024
    Configuration menu
    Copy the full SHA
    d4c2f27 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. Fixed superflous pre-commit errors

    @Maralai
    Maralai committed May 26, 2024
    Configuration menu
    Copy the full SHA
    4d58a97 View commit details
    Browse the repository at this point in the history

  2. another superflous run pre-commit error fix

    @Maralai
    Maralai committed May 26, 2024
    Configuration menu
    Copy the full SHA
    b3d8e72 View commit details
    Browse the repository at this point in the history

  3. Implemented TODOs

    @Maralai
    Maralai committed May 26, 2024
    Configuration menu
    Copy the full SHA
    9434551 View commit details
    Browse the repository at this point in the history

  4. refactored to pass pre-commit

    @Maralai
    Maralai committed May 26, 2024
    Configuration menu
    Copy the full SHA
    386ee41 View commit details
    Browse the repository at this point in the history

  5. requirements is generated, removed aiohttp

    @Maralai
    Maralai committed May 26, 2024
    Configuration menu
    Copy the full SHA
    b3cb98a View commit details
    Browse the repository at this point in the history

  6. refactored to pass run pre-commit

    @Maralai
    Maralai committed May 26, 2024
    Configuration menu
    Copy the full SHA
    8c4b0ea View commit details
    Browse the repository at this point in the history

  7. Updated whitespace and import block

    @Maralai
    Maralai committed May 26, 2024
    Configuration menu
    Copy the full SHA
    f99448b View commit details
    Browse the repository at this point in the history

  8. reformated with ruff linter

    @Maralai
    Maralai committed May 26, 2024
    Configuration menu
    Copy the full SHA
    6789e54 View commit details
    Browse the repository at this point in the history

  9. fixed ruff formatting requirements

    @Maralai
    Maralai committed May 26, 2024
    Configuration menu
    Copy the full SHA
    bf18539 View commit details
    Browse the repository at this point in the history

  10. Removed caveats as they are addressed in updated codebase

    @Maralai
    Maralai committed May 26, 2024
    Configuration menu
    Copy the full SHA
    8405be4 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Added tests

    @Maralai
    Maralai committed May 27, 2024
    Configuration menu
    Copy the full SHA
    76dea04 View commit details
    Browse the repository at this point in the history

  2. removed whitespace

    @Maralai
    Maralai committed May 27, 2024
    Configuration menu
    Copy the full SHA
    8c43c04 View commit details
    Browse the repository at this point in the history

  3. added back dependency as tests are failing without.

    @Maralai
    Maralai committed May 27, 2024
    Configuration menu
    Copy the full SHA
    97fa439 View commit details
    Browse the repository at this point in the history

  4. reduced coverage for testing after debugging.

    @Maralai
    Maralai committed May 27, 2024
    Configuration menu
    Copy the full SHA
    dad9f25 View commit details
    Browse the repository at this point in the history

  5. declared external dependency

    @Maralai
    Maralai committed May 27, 2024
    Configuration menu
    Copy the full SHA
    fb5975d View commit details
    Browse the repository at this point in the history

  6. reset the requirements

    @Maralai
    Maralai committed May 27, 2024
    Configuration menu
    Copy the full SHA
    2dd28d4 View commit details
    Browse the repository at this point in the history

  7. added it back but in alphabetical order.

    @Maralai
    Maralai committed May 27, 2024
    Configuration menu
    Copy the full SHA
    3c0acdc View commit details
    Browse the repository at this point in the history

  8. modify the test setup to mock the thread creation and event loop init… 

    …ialization
    @Maralai
    Maralai committed May 27, 2024
    Configuration menu
    Copy the full SHA
    c3e9833 View commit details
    Browse the repository at this point in the history

  9. updated to pass formating.

    @Maralai
    Maralai committed May 27, 2024
    Configuration menu
    Copy the full SHA
    e2a3b22 View commit details
    Browse the repository at this point in the history

  10. changed quotations to pass....

    @Maralai
    Maralai committed May 27, 2024
    Configuration menu
    Copy the full SHA
    1e45683 View commit details
    Browse the repository at this point in the history

  11. dang + sign, sorry for all the commits...

    @Maralai
    Maralai committed May 27, 2024
    Configuration menu
    Copy the full SHA
    edb36b3 View commit details
    Browse the repository at this point in the history

  12. reduced test cases

    @Maralai
    Maralai committed May 27, 2024
    Configuration menu
    Copy the full SHA
    b7405da View commit details
    Browse the repository at this point in the history

  13. reduced test coverage based on testing

    @Maralai
    Maralai committed May 27, 2024
    Configuration menu
    Copy the full SHA
    6582397 View commit details
    Browse the repository at this point in the history