[16.0] [FIX] base_import_async: remove default values from context when creating the attachment #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marielejeune
changed the title
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
@OCA/core-maintainers @guewen Could you reopen this and review ? |
guewen
approved these changes
Sep 18, 2023
…ting the attachment. Some default values might be present in context depending on the action we came from when clicking on 'import' button. These default values are not intended to be default values for the ir.attachment record. In some cases they cause an error because a field with the same name exists on ir.attachment, as for e.g. the 'default_type'='opportunity' value present in the standard crm.lead action context.
marielejeune
force-pushed
the
16.0-base_import_async_attachment_context_fix-mle
branch
from
48f41dd
to
db24c87
Compare
|
Rebased on 16.0 + fixed pre-commit. |
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Thanks! |
|
Congratulations, your PR was merged at f80f09d. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some default values might be present in context depending on the action we came from when clicking on 'import' button. These default values are not intended to be default values for the ir.attachment record.
In some cases they cause an error because a field with the same name exists on ir.attachment, as for e.g. the
'default_type'='opportunity'value present in the standard crm.lead action context.