Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] product_profile #1731

Open
wants to merge 58 commits into
base: 17.0
Choose a base branch
from
Open

Conversation

bosd
Copy link
Contributor

@bosd bosd commented Sep 30, 2024

No description provided.

bealdav and others added 30 commits September 30, 2024 12:29
…care about the current value we just want to write the data of the profile
…prefix (profile_default_) ex: profile_default_categ_id
sebastienbeau and others added 20 commits September 30, 2024 12:29
Currently translated at 100.0% (30 of 30 strings)

Translation: product-attribute-14.0/product-attribute-14.0-product_profile
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_profile/ca/
Give the possibility to call directly with a domain the method _customize_view
with a domain so you can reuse this method in custom module to add profile filter.

In my case I want to add a filter on mrp.bom so just adding a related
field + a call to _customize_view allow to add only profile related to
manufacturing

Also add a separator to avoid mixing profile filter with existing filter
Currently translated at 100.0% (30 of 30 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_profile
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_profile/it/
Currently translated at 100.0% (30 of 30 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_profile
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_profile/nl_NL/
Currently translated at 100.0% (30 of 30 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_profile
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_profile/it/
Fixes the warning "The model odoo.addons.product_profile is not overriding the create method in batch"

Fixup! Update product_profile
@bosd
Copy link
Contributor Author

bosd commented Sep 30, 2024

@sbidoul, @rousseldenis Can you please review this one as well.

@bosd bosd mentioned this pull request Sep 30, 2024
58 tasks
@yvaucher
Copy link
Member

/ocabot migration product_profile

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Sep 30, 2024
Copy link
Member

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you restore the previous indents of the xml file? IMO, current state makes it less readable.

type="action"
string="Product Profiles"
class="btn-link"
/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indent is a bit messed up, it alter the readability as <button has more spaces that it's closing />

Copy link
Contributor Author

@bosd bosd Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yvaucher
I've manually edited the indentation. Then run pre-commit and forced pushed. Should be ok now.

<div class="col-12 col-lg-6 o_setting_box">
<div class="o_setting_left_pane">
<xpath expr="//block[@name='catalog_setting_container']" position="inside">
<setting>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems over indented, not blocking for this though.

Update product_profile.py

refactor for V17 way

[IMP] product_profile: pre-commit execution

Fixup product_profile.py
Copy link

@Dranyel-Bosd Dranyel-Bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.