-
-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] product_profile #1731
base: 17.0
Are you sure you want to change the base?
Conversation
…care about the current value we just want to write the data of the profile
…prefix (profile_default_) ex: profile_default_categ_id
…oducts for some fields
Currently translated at 100.0% (30 of 30 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_profile Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_profile/ca/
Give the possibility to call directly with a domain the method _customize_view with a domain so you can reuse this method in custom module to add profile filter. In my case I want to add a filter on mrp.bom so just adding a related field + a call to _customize_view allow to add only profile related to manufacturing Also add a separator to avoid mixing profile filter with existing filter
Currently translated at 100.0% (30 of 30 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_profile Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_profile/it/
Currently translated at 100.0% (30 of 30 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_profile Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_profile/nl_NL/
Currently translated at 100.0% (30 of 30 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_profile Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_profile/it/
Fixes the warning "The model odoo.addons.product_profile is not overriding the create method in batch" Fixup! Update product_profile
@sbidoul, @rousseldenis Can you please review this one as well. |
0eddb6b
to
8f105a8
Compare
/ocabot migration product_profile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you restore the previous indents of the xml file? IMO, current state makes it less readable.
type="action" | ||
string="Product Profiles" | ||
class="btn-link" | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This indent is a bit messed up, it alter the readability as <button
has more spaces that it's closing />
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yvaucher
I've manually edited the indentation. Then run pre-commit and forced pushed. Should be ok now.
<div class="col-12 col-lg-6 o_setting_box"> | ||
<div class="o_setting_left_pane"> | ||
<xpath expr="//block[@name='catalog_setting_container']" position="inside"> | ||
<setting> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems over indented, not blocking for this though.
Update product_profile.py refactor for V17 way [IMP] product_profile: pre-commit execution Fixup product_profile.py
8f105a8
to
c3deb6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
No description provided.