Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][Add] pos_product_pricelist_alternative #1235

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

santostelmo
Copy link

@santostelmo santostelmo commented Sep 18, 2024

POS product pricelist allternative is based on the same logic of OCA/product_pricelist_alternative which allows you to define alternative price lists to a reference price list.
As a general rule, the price of a given product is obtained from the minimum between its reference price list and the alternative price lists.

@santostelmo santostelmo force-pushed the 16.0-add-pos_product_pricelist_alternative branch 2 times, most recently from 69095cb to 97ad006 Compare September 18, 2024 07:33
@santostelmo santostelmo marked this pull request as draft September 18, 2024 07:40
@santostelmo
Copy link
Author

santostelmo commented Sep 18, 2024

Unit tests on CI are falling but nothing seem related with this PR.
To be sure I commented my code here to check if CI still fails
a8f1377
28ea3dd

@santostelmo santostelmo force-pushed the 16.0-add-pos_product_pricelist_alternative branch from 28ea3dd to c108114 Compare September 18, 2024 08:20
@santostelmo santostelmo marked this pull request as ready for review September 18, 2024 08:20
@santostelmo santostelmo force-pushed the 16.0-add-pos_product_pricelist_alternative branch 3 times, most recently from fc2aba9 to 1e73ccd Compare September 18, 2024 09:17
Copy link
Contributor

@Ricardoalso Ricardoalso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart the use of IMO unnecessary var statement

pos_product_pricelist_alternative/static/src/models.js Outdated Show resolved Hide resolved
pos_product_pricelist_alternative/static/src/models.js Outdated Show resolved Hide resolved
pos_product_pricelist_alternative/static/src/models.js Outdated Show resolved Hide resolved
pos_product_pricelist_alternative/static/src/models.js Outdated Show resolved Hide resolved
@santostelmo santostelmo force-pushed the 16.0-add-pos_product_pricelist_alternative branch from 1e73ccd to 655ec88 Compare September 18, 2024 11:20
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG 👍🏻

It'd be super nice to add a simple test tour to test a product with an alternative price set 🙏🏻

I'm checking the red CI

@@ -0,0 +1,2 @@
POS product pricelist allternative is based on the same logic of `OCA/product_pricelist_alternative: <https://github.com/OCA/product-attribute/tree/16.0/product_pricelist_alternative>` which allows you to define alternative price lists to a reference price list.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
POS product pricelist allternative is based on the same logic of `OCA/product_pricelist_alternative: <https://github.com/OCA/product-attribute/tree/16.0/product_pricelist_alternative>` which allows you to define alternative price lists to a reference price list.
POS product pricelist alternative is based on the same logic of `OCA/product_pricelist_alternative: <https://github.com/OCA/product-attribute/tree/16.0/product_pricelist_alternative>` which allows you to define alternative price lists to a reference price list.

@simahawk
Copy link

I'm checking the red CI

The same error happened on #1220. I forced running tests on 16.0

@simahawk
Copy link

#1236

@santostelmo santostelmo force-pushed the 16.0-add-pos_product_pricelist_alternative branch from 655ec88 to 36ee150 Compare September 24, 2024 09:23
@legalsylvain
Copy link
Contributor

rebase should fix the CI.

@santostelmo santostelmo force-pushed the 16.0-add-pos_product_pricelist_alternative branch from 36ee150 to 03d4cd7 Compare September 26, 2024 04:18
@santostelmo
Copy link
Author

rebase should fix the CI.

Done

@santostelmo santostelmo force-pushed the 16.0-add-pos_product_pricelist_alternative branch from 03d4cd7 to 025f7d9 Compare October 1, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants