[MIG] pos_cash_move_reason: Migration to 17.0

pos_cash_move_reason/README.rst

@@ -149,6 +149,7 @@ Contributors
 
 -  Sylvain LE GAL <https://twitter.com/legalsylvain>
 -  Dhara Solanki <[email protected]>
+-  Tran Thanh Trai <[email protected]>
 
 Maintainers
 -----------

pos_cash_move_reason/__manifest__.py

@@ -6,12 +6,11 @@
     "author": "ACSONE SA/NV," "GRAP," "Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/pos",
     "category": "Point Of sale",
-    "version": "16.0.1.0.0",
+    "version": "17.0.1.0.0",
     "license": "AGPL-3",
     "depends": ["point_of_sale"],
     "data": [
         "security/ir_rule.xml",
-        "security/res_groups.xml",
         "security/ir.model.access.csv",
         "views/view_pos_move_reason.xml",
         "views/view_pos_session.xml",

pos_cash_move_reason/readme/CONTRIBUTORS.md

@@ -1,2 +1,3 @@
 - Sylvain LE GAL \<<https://twitter.com/legalsylvain>\>
 - Dhara Solanki \<<[email protected]>\>
+- Tran Thanh Trai \<<[email protected]>\>

pos_cash_move_reason/tests/test_pos_cash_move_reason.py

@@ -14,13 +14,14 @@ def setUpClass(cls):
         cls.WizardReason = cls.env["wizard.pos.move.reason"]
         cls.AccountMoveLine = cls.env["account.move.line"]
 
-        cls.config = cls.env.ref("point_of_sale.pos_config_main").copy()
+        cls.config = cls.env.ref("point_of_sale.pos_config_main")
         cls.cash_journal = cls.env["account.journal"].search(
             [
                 ("type", "=", "cash"),
                 ("company_id", "=", cls.env.ref("base.main_company").id),
-            ]
-        )[0]
+            ],
+            limit=1,
+        )
         cls.deposit_reason = cls.env.ref("pos_cash_move_reason.bank_out_reason")
 
     def test_onchange_expense_reason(self):
@@ -70,7 +71,6 @@ def test_take_invalid_amount(self):
         session = self.PosSession.search(
             [("state", "=", "opening_control"), ("config_id", "=", self.config.id)]
         )
-
         # Enter Invalid money
         with self.assertRaises(UserError):
             self.WizardReason.with_context(
@@ -88,7 +88,7 @@ def test_take_invalid_amount(self):
     def test_button_put_money(self):
         self.config._action_to_open_ui()
         session = self.PosSession.search(
-            [("state", "=", "opened"), ("config_id", "=", self.config.id)]
+            [("state", "=", "opening_control"), ("config_id", "=", self.config.id)]
         )
         wiz = session.button_move_income()
         self.assertEqual(wiz["context"]["default_move_type"], "income")

pos_cash_move_reason/views/view_pos_move_reason.xml

@@ -43,16 +43,14 @@
                         <field name="is_income_reason" />
                         <field
                             name="income_account_id"
-                            attrs="{
-                            'required': [('is_income_reason', '=', True)],
-                            'invisible': [('is_income_reason', '=', False)]}"
+                            required="is_income_reason"
+                            invisible="not is_income_reason"
                         />
                         <field name="is_expense_reason" />
                         <field
                             name="expense_account_id"
-                            attrs="{
-                            'required': [('is_expense_reason', '=', True)],
-                            'invisible': [('is_expense_reason', '=', False)]}"
+                            required="is_expense_reason"
+                            invisible="not is_expense_reason"
                         />
                     </group>
                 </sheet>

pos_cash_move_reason/views/view_pos_session.xml

@@ -13,9 +13,7 @@
                     name="button_move_income"
                     type="object"
                     icon="fa-level-down"
-                    attrs="{'invisible': ['|',
-                        ('display_move_reason_income', '=', False),
-                        ('state', 'not in', ['opened', 'closing_control'])]}"
+                    invisible="not display_move_reason_income or state not in ('opened', 'closing_control')"
                 >
                     <div class="o_field_widget o_stat_info">
                         <span class="o_stat_text">Put</span>
@@ -28,9 +26,7 @@
                     name="button_move_expense"
                     type="object"
                     icon="fa-level-up"
-                    attrs="{'invisible': ['|',
-                        ('display_move_reason_expense', '=', False),
-                        ('state', 'not in', ['opened', 'closing_control'])]}"
+                    invisible="not display_move_reason_expense or state not in ('opened', 'closing_control')"
                 >
                     <div class="o_field_widget o_stat_info">
                         <span class="o_stat_text">Take</span>

pos_cash_move_reason/wizard/wizard_pos_move_reason.xml

@@ -6,20 +6,17 @@
             <form>
                 <separator
                     string="Fill in this form if you put money in the cash register"
-                    attrs="{'invisible': [('move_type', '=', 'expense')]}"
+                    invisible="move_type == 'expense'"
                 />
                 <separator
                     string="Describe why you take money from the cash register"
-                    attrs="{'invisible': [('move_type', '=', 'income')]}"
+                    invisible="move_type == 'income'"
                 />
                 <group>
                     <field name="move_type" invisible="1" />
                     <field name="session_id" />
                     <field name="move_reason_id" />
-                    <field
-                        name="journal_id"
-                        attrs="{'invisible': [('move_reason_id', '=', False)]}"
-                    />
+                    <field name="journal_id" invisible="not move_reason_id" />
                     <field name="journal_ids" invisible="1" />
                     <field name="name" />
                     <field name="amount" />