Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] partner_identification_unique_by_category: Migration to 18.0 #1859

Open
wants to merge 12 commits into
base: 18.0
Choose a base branch
from

Conversation

chaule97
Copy link

@chaule97 chaule97 commented Oct 9, 2024

@chaule97 chaule97 force-pushed the 18.0-mig-partner_identification_unique_by_category branch 3 times, most recently from f2d8ef6 to d25bbde Compare October 10, 2024 08:06

from odoo.exceptions import ValidationError

from odoo.addons.base.tests.common import SavepointCaseWithUserDemo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from odoo.addons.base.tests.common import SavepointCaseWithUserDemo
from odoo.tests.common import TransactionCase

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TDu , I have updated it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@chaule97 chaule97 force-pushed the 18.0-mig-partner_identification_unique_by_category branch from d25bbde to d0bfab2 Compare October 14, 2024 03:27
@chaule97 chaule97 requested a review from TDu October 14, 2024 03:32
@rousseldenis
Copy link
Contributor

/caobot migration partner_identification_unique_by_category

@rousseldenis rousseldenis added this to the 18.0 milestone Oct 18, 2024
@rousseldenis
Copy link
Contributor

@chaule97 Thanks for this. Don't forget to add the depending PR in this one description to help review

@OCA-git-bot
Copy link
Contributor

Sorry @TDu you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants