[ADD] convert_from_company_dependent

[hbrunn]

this is the function I propose in OCA/OpenUpgrade#4457 (comment), will be useful elsewhere too

[pedrobaeza]

But I think this depends on the business logic behind, as you are converting a multi-valued field (potentially one per company) into only one value, so you need to decide what to do in case of conflict depending on the use case.

[hbrunn]

I think the general case will be pretty much the same everywhere:

v(n-1): model has no company_id and property property_whatever
v(n): model has company_id, property_whatever becomes field whatever

Then the user of the function duplicates every row of model for each company where it makes sense (that's the business logic depending part), and calls convert_from_company_dependent(model, property_whatever, whatever), which is invariant wrt business logic

[pedrobaeza]

But in such duplication, res_id will be another, and thus, this method won't serve for transferring the value of the corresponding property for the duplicated records.

[hbrunn]

it will, because the caller sets company_id for the cloned records as it's appropriate.

consider the account migration, there they duplicate tax groups as it makes sense into the different companies, and in the next function I can replace the horrible incomplete sql statements with three calls to the function I propose.

Wherever Odoo decides to go from properties to company aware on model level, we need the exact same thing.

[pedrobaeza]

I insist that this is the problem. The duplicated record has an ID that is not on ir_property table, as the corresponding one is the previous record ID.

[hbrunn]

thanks for insisting, see below

[hbrunn]

aaah wait, I get it now. This indeed needs the extra field I propose on the PR to link the clones to their origin record. That's a good thing to have in those cases anyways, will do next week