Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Convert tax tags based on move type instead of amount. #383

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ddejong-therp
Copy link
Contributor

@ddejong-therp ddejong-therp commented Sep 30, 2024

Like the title says.

The issue is that tax tags shouldn't be based on whether a line is of positive or negative amount, but e.g. whether it is an 'invoice' or 'refund'.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may have tax tags on other moves different from invoices (for example, payroll moves), so I don't think this is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants