Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] hr_expense_tier_validation #227

Open
wants to merge 36 commits into
base: 17.0
Choose a base branch
from

Conversation

WorrapongOngsakul
Copy link

No description provided.

@kittiu
Copy link
Member

kittiu commented Mar 15, 2024

Please use module name like this on subject, it is easier to search by others, e.g., hr_expense_tier_validation

@WorrapongOngsakul WorrapongOngsakul changed the title [17.0][MIG] hr expense tier validation [17.0][MIG] hr_expense_tier_validation Mar 15, 2024
@kittiu
Copy link
Member

kittiu commented Mar 19, 2024

@WorrapongOngsakul can you squashed your commit (2 commit into 1 commit).
Please note that, you can also use git commit --amend if you don't want to add more commits.

@WorrapongOngsakul WorrapongOngsakul force-pushed the 17.0-mig-hr_expense_tier_validation branch from 971df3b to d7165f8 Compare March 20, 2024 06:38
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 21, 2024
@Saran440 Saran440 removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 23, 2024
ps-tubtim and others added 23 commits July 23, 2024 10:23
…validate the tier validation, then the user has to click the Submit to Manager button. By this PR, requester has to click the Submit to Manager button first, then the tier validation is activated.
Currently translated at 100.0% (18 of 18 strings)

Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_tier_validation/it/
OCA-git-bot and others added 13 commits July 23, 2024 10:23
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_tier_validation/
Currently translated at 100.0% (19 of 19 strings)

Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_tier_validation/it/
Currently translated at 100.0% (19 of 19 strings)

Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_tier_validation/it/
Currently translated at 100.0% (19 of 19 strings)

Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_tier_validation/it/
Currently translated at 100.0% (19 of 19 strings)

Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_tier_validation/it/
Currently translated at 100.0% (19 of 19 strings)

Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_tier_validation/it/
@Saran440 Saran440 force-pushed the 17.0-mig-hr_expense_tier_validation branch from 8cd54fe to 5645960 Compare July 23, 2024 03:24
@Saran440
Copy link
Member

  • Delete file hr.expense can use core tier validation
  • Fixes test script

Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Test 👍

@Saran440
Copy link
Member

/ocabot migration hr_expense_tier_validation

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 23, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 23, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.