Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] hr_attendance_calendar_view: Migration to 17.0 #174

Merged
merged 8 commits into from
Aug 12, 2024

Conversation

lbarry-apsl
Copy link
Member

@lbarry-apsl lbarry-apsl commented Aug 9, 2024

Module migrated to version 17.0

cc https://github.com/APSL 159331

@miquelalzanillas @BernatObrador @mpascuall @peluko00 @javierobcn @ppyczko please review

@lbarry-apsl lbarry-apsl mentioned this pull request Aug 9, 2024
6 tasks
@peluko00
Copy link

peluko00 commented Aug 9, 2024

The both commit messages needs to be changed

@mpascuall
Copy link

You have to add yourself in the contributors file, not in readme

@lbarry-apsl lbarry-apsl force-pushed the 17.0-mig-hr_attendance_calendar_view branch from 9a91393 to 38c4612 Compare August 12, 2024 06:47
@lbarry-apsl
Copy link
Member Author

The both commit messages needs to be changed

Done

Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the pull request following this pattern: [17.0][MIG] <module>: Migration to 17.0.
Otherwise, tested in runboat and LGTM.

@lbarry-apsl lbarry-apsl changed the title 17.0 mig hr attendance calendar view [17.0][MIG] hr_attendance_calendar_view: Migration to 17.0 Aug 12, 2024
@lbarry-apsl
Copy link
Member Author

You have to add yourself in the contributors file, not in readme

Please rename the pull request following this pattern: [17.0][MIG] : Migration to 17.0. Otherwise, tested in runboat and LGTM.

Done, thanks

Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested in runboat

Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

Copy link

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza
Copy link
Member

/ocabot migration hr_attendance_calendar_view
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Aug 12, 2024
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-174-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c417b9a into OCA:17.0 Aug 12, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2d07cb1. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants