[17.0][MIG] web_leaflet_lib

[legalsylvain]

Trivial migration.

Commit to review : c570d60

• to be used by 17.0: Widget map and new map field web#2953
• supersed : 17.0: Migration for web_leaflet_lib #381

[legalsylvain]

/ocabot migration web_leaflet_lib

[OCA-git-bot]

Sorry @legalsylvain you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

[weinni2000]

@legalsylvain:
Did you also already convert web_view_leaflet_map to 17/18?
Because otherwise I would like to contribute to that. There is already a demo project in OWL2 from AJScript
https://github.com/ajscriptmedia/odoo-map-view-type/tree/model-arch-parser
Do you know who is the maintainer of geospatial because I need help on the PR for the base geoengine migration to 18.

[legalsylvain]

Hi @weinni2000.

• I didn't planned to migrate web_view_leaflet_map in v17 / V18. Feel free to do it. (I'm working on v16, and the next version I'll work is version 20).
• You can find who are the maintainers of the geospatial repo here : https://github.com/OCA/repo-maintainer-conf/blob/master/conf/psc/geospatial.yml. CC : @lmignon, @yvaucher

regards.

[yvaucher]

/ocabot migration web_leaflet_lib

[OCA-git-bot]

The migration issue (#349) has not been updated to reference the current pull request because a previous pull request (#381) is not closed.
Perhaps you should check that there is no duplicate work.
CC @drkpkg

[lmignon]

/ocabot migration web_leaflet_lib

[yvaucher]

@weinni2000 Noone volunteered to migrate web_view_leaflet_map yet, contributions are welcome
If you do so please leave a note in one of those issues:
in 17.0 #349
in 18.0 #379

[legalsylvain]

Hi. could we merge this trivial one to unblock : OCA/web#2953

thanks !

[lmignon]

/ocabot merge nobump

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-383-by-lmignon-bump-nobump, awaiting test results.

[OCA-git-bot]

@lmignon your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-383-by-lmignon-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[legalsylvain]

@lmignon could you retry ?
the error is related to an error in a call of an unmocked external API.
see : https://github.com/OCA/geospatial/actions/runs/11928567537/job/33245772449#step:8:100

thanks !

[lmignon]

/ocabot merge nobump

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-383-by-lmignon-bump-nobump, awaiting test results.

[lmignon]

@lmignon could you retry ? the error is related to an error in a call of an unmocked external API. see : https://github.com/OCA/geospatial/actions/runs/11928567537/job/33245772449#step:8:100

thanks !

We should mock the call....

[OCA-git-bot]

Congratulations, your PR was merged at c567808. Thanks a lot for contributing to OCA. ❤️

[legalsylvain]

We should mock the call....

Arf. There are pro and cons that has been detailled in another Issue / PR. don't find right now the URL, but As far as I remember : Pro : CI is not failing randomly. Cons : we are not testing if the connection to the API works, but we are testing if an emulation of the API works, and API could have changed.
I have no clear point of view on that topic.

Note :

• the error is on geoengine_base_geolocalize module that you are maintaining.
• If I understand correctly, base_geolocalize core module is also related to that error. Not sure how we can mook a core test and we should do it.

Anyway, thanks for the merge !