Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] dms_field: Incompatibility with web_responsive #353

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

CarlosRoca13
Copy link

@CarlosRoca13 CarlosRoca13 commented Jul 26, 2024

When we edit the name of a file or directory while positioned in a field, like the one added by hr_dms_field with web_responsive installed, the input text appears white, making it impossible to edit.
white

With these changes, the text appears black and can be edited normally.
black

cc @Tecnativa TT50329

ping @victoralmau @pedrobaeza

When we edit the name of a file or directory while positioned in a field,
like the one added by hr_dms_field with web_responsive installed, the
input text appears white, making it impossible to edit.

With these changes, the text appears black and can be edited normally.
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok

@pedrobaeza pedrobaeza added this to the 16.0 milestone Jul 26, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very friend of !important, but it's a specific case that can't be solved other way.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-353-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ce2b40a into OCA:16.0 Jul 26, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 36bd986. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-IMP-dms_field branch July 26, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants