-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] dms_partner_attachment_link: add module #349
base: 16.0
Are you sure you want to change the base?
[ADD] dms_partner_attachment_link: add module #349
Conversation
Which is the difference with https://github.com/OCA/dms/tree/15.0/dms_attachment_link ? |
And why not using |
The difference is that dms_attachment_link adds a wizard for files quick creation from records of specific models. This module just adds a shortcut to see partner related files. I hope that is clear, please let me know if I'm wrong |
Well, not really clear the usefulness of this, but it's OK, don't worry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather a question yet...
"domain": [ | ||
("res_id", "=", self.id), | ||
("res_model", "=", "res.partner"), | ||
("storage_id.save_type", "=", "attachment"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this storage_id
domain condition for?
Shouldn't all the files be shown no matter where they are stored?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the task description: "Keep in mind that we can find related partners only for files that are stored in the Attachment Storages"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivs-cetmix see also readme/DESCRIPTION.md file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I understand the need for this module, doing so will always make a new one necessary for almost any model and I think that is not a good approach.
My approach to this would be more transversal (maybe add it even in the dms
module), add an action automatically in the form view of a record (only if there is some document: folder or file) called "View Documens" (or similar) and that when clicked we go to the "Files" action (kanban view) with the folder of the record selected. what do you think?
…d when view was opened via partner form
c1e2297
to
5b76268
Compare
This module adds "DMS Attachments" smart button to the partner's form leading to a set of related, stored as attachments DMS files