[16.0][FIX] dms: Fix share action #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victoralmau
changed the title
|
AFAIK, this works without ACL having "Contact creation" permission. |
victoralmau
force-pushed
the
16.0-fix-dms-share
branch
from
7d6621b
to
3eb3e93
Compare
|
Changed with v15 approach (fwp) |
pedrobaeza
reviewed
Jun 19, 2024
…ion' permission Extra changes: Replace Share buttons with actions Steps to reproduce: - Go to Settings > Users & Companies > Users and create a user only with Documents > Manager permission. (User must not have the Extra Rights > Contact Creation permission). - Go to Documents and go into a directory form view and click on "Share" button. - An access error is displayed
victoralmau
force-pushed
the
16.0-fix-dms-share
branch
from
3eb3e93
to
a60156e
Compare
pedrobaeza
approved these changes
Jun 19, 2024
|
/ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at c0e6e2a. Thanks a lot for contributing to OCA. ❤️ |
|
Thanks for this fix 👍 |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FWP from 15.0: #345
Allow share (directories and files) without 'Contact creation' permission
Extra changes: Replace Share buttons with actions
Steps to reproduce:
Fixes #343
Please @pedrobaeza can you review it?
@Tecnativa