[17.0][MIG] DMS : Migration to 17.0 #323

…ails, preview

versions of muk_dms than 12.0.2.0.0. Tested from 1.2.4 version.

In v13, this test is programmed in such a way that the demo user is supposed to be able to copy that subdirectory: https://github.com/OCA/dms/blob/c3f802db43362127e70d8c7b4987fb71d4c1f01c/dms/tests/test_directory.py#L40 However, in OCA#7 that test was modified indicating that demo user didn't have permissions to do that: https://github.com/OCA/dms/blob/e3b6d8d24534f2a68bfb88e310cc70cefe46bb64/dms/tests/test_directory.py#L39 Rolling back that change to ensure premissions remain the same in both versions of the module. Also changing the directory to test to ensure it contains no SVG files, whose detection seems to differ among environments, and which have some specific permission restrictions that can make the modified test fail or pass. @Tecnativa TT25645

…tions

[IMP] dms: Attachment integration

…le + remove content field in tree

… and auto-create directories and files if is needed) to prevent error in attachment(s) creation Co-authored-by: Jairo Llopis <[email protected]>

…fields or functions that is used in some models (in these case some fields appear in directory and field and some functions about it). Fixed problem happen when access to file or folder view if record ref is set (file or folder has been created in attachment creation in partner for example)

…o create again + Add test to check it

Fixes issue OCA#69

When creating an attachment, check `default_directory_id` too because this key comes from kanban js view and it's like `active_id` when creating files from drag and drop (drop target). This change will allow to view the new file on the associated record if the folder has `res_model` and `res_id` (the parent folder is an attachment storage) Fixes OCA#72

…IX] dms: Change allowed_model_ids field in directory to related [FIX] dms: Change res_model + res_id fields in files to related

…nvert file name to link (download)

…fter dms install and new addons auto-create partners

…to files) to get only records to get only allowed records according to directories groups.

... so to speak. @Tecnativa TT29847

When some dms.directory or dms.file was related to a real DB record (a.k.a. attachment storage), if the record got deleted, the DMS mirror was still alive. If the dms.storage had inherit_access_from_parent_record=True, the situation got worse because the dms.directory became visible to everyone. @Tecnativa TT30223

Module upgrade is done in a constrained environment where the `dms` module is only aware of models declared in its dependency tree. If some upgrade operation tries to write to a file or directory that is attached to a model-based storage, the upgrade would fail with a `KeyError` when trying to get the model. This fix allows normal and predictable upgrades in such cases. @Tecnativa TT29847

- Portal was too slow to load because every thumbnail came base64-encoded. Instead, now it loads resources externally, making the initial request much faster, and benefiting from caching. - Fields `custom_thumbnail_medium` and `custom_thumbnail_small` are now stored, because non-stored thumbnails become performance bottlenecks easily. - Added field `icon_url` that allows using always the exact same image path for the exact same mime type. This saves a lot of requests and bandwidth. - Fields `thumbnail`, `thumbnail_medium` and `thumbnail_small` are now only used in forms, and do not perform resize operations. - Remove unused `size` parameter in thumbnail internal getters. - All thumbnail fields were getting resized to sizes that were different from the sizes that, later, were actually used in UI, thus making the UI always re-resize them. Removed that nonsense. Thumbnails now use the same size that the UI will require, and then UI needs to ask for no resizes. - Typo fixed in unknown file default thumbnail. - Do your customers really know what a mime type is? I bet not. Remove "type" column from portal. Thumbnails provide all the required information. @Tecnativa TT29847

- Remove `perm_read` field from `dms.access.group`. It is redundant to the mere existence of the group. Otherwise, users could be able to create, write or unlink records that they cannot read. To avoid confusion, it is removed. - Add portal group access to mails directory, to make one test pass. This was a false positive before. - Forbid `dms.access.group` recursiveness. - Compute inclusive permissions in `dms.access.group`, which combine current group with parent group permissions. - Rely on domain search of `permission_{create,read,unlink,write}` in `dms.directory` and `dms.file` when checking those accesses to records. These search methods are improved to reflect permission reality and add it to the domain. - Added a hack to workaround situations where the current context user is superuser, but it's actually checking for other user permissions. - These checks are added as normal `ir.rule` records. - To create something in a directory, you need create access in the parent directory. - For other operations, and only in subdirs, the own dir access is checked. - Batch operations when checking inherited permissions. - Remove many custom methods to check access, now that we use ORM's. - Fix custom cascade dir unlink. - Use `consteq()` when checking access tokens, for security. - Remove duplicated security computations from `dms.directory` and `dms.file`. Use proper inheritance. - Use `ir.rule` for checking locked files. - Add or fix tests for new permissions model. - Define groups to root folder "Media" (according to the previous expected operation). - Add the Admin + Demo user group to "Mails" folder (according to the previous expected operation). - Add sudo() in the creation of the directory to "force" that it can be created because the correct parameter of permission_read can only be correctly defined when the record exists and the complete_group_ids records have been created (in 13.0 it is not necessary). - Add default group (Admin + Demo user) when creating directive in tests. - Corrections tests of record_ref - Fix prevent error related to mail_message parent not exists in some cases (directory) @Tecnativa TT29847 Co-authored-by: Víctor Martínez <[email protected]>

The fix is similar to [v12 creation workaround][1], with some differences: 1. It is applied to both `dms.directory` and `dms.file`, as both need to use this. 2. In v13 Odoo uses now `_filter_access_rules_python()` by default, which is incompatible with DMS' security hack, so we make use of `_filter_access_rules()` always. Some comments explain the HACK. 3. `flush()` before doing the creation access check, so all data is in DB before we issue the `SELECT` needed to check permissions properly. [1]: https://github.com/OCA/dms/blob/db9cb933ba4f29cc1a610190c32e2ff4bb16b1ce/dms/models/directory.py#L654-L661

…ad from files creation in _compute_path() if some directory not allowed from user

…sers Instead of relying on base users, create the ones we need for the test.

- If a dms.file contains an image, use it as thumbnail automatically, and hide controls for customizing that record's thumbnail. - Remove `.png` icons, unused. - Clarify distinction between icon and thumbnail. - Inherit from `image.mixin` for thumbnails. - Save custom thumbnails as attachments instead of db binary fields. @Tecnativa TT31004

…ch panel

…m view of the directories.

…xtension in the file name).

…d use cases. TT34095

…47483647 limit from postgresql. TT33935

…e directory (file_ids field) because it is totally wrong to try to show that field. TT34353

…new group.

…from tree views.

Currently translated at 98.2% (333 of 339 strings) Translation: dms-15.0/dms-15.0-dms Translate-URL: https://translation.odoo-community.org/projects/dms-15-0/dms-15-0-dms/de/

- Set limit=0 to prevent js default limit https://github.com/odoo/odoo/blob/15.0/addons/web/static/src/search/search_arch_parser.js#L10 - Removes the context of fields (not used in .js calls). - Display the short name of the category (no hierarchy) in Directory menu.

…field - Remove path_names field - Remove FieldPathNames (related to path_names)

… All text to Root) + Change to searchpanel directory_id (in files) or parent_id (in directories) to filter equal and not child_of

We need to overwrite function from directories because odoo only return records with childs (very weird for user perspective). All records are returned now.

…om attachment

…search panel directory). TT41585

…s to. TT41585

…ich you have access) in the portal view. TT41585

…ord field

TT41512

The method _compute_image_1920 of dms_file checks if the file is of mimetype image and tries to use it as a thumbnail. However, there are several types of image files that Odoo/PIL cannot work with, leading to the following error: ``` Traceback (most recent call last): File "/opt/odoo/custom/src/odoo/odoo/tools/image.py", line 404, in base64_to_image return Image.open(io.BytesIO(base64.b64decode(base64_source))) File "/usr/local/lib/python3.6/site-packages/PIL/Image.py", line 2687, in open % (filename if filename else fp)) OSError: cannot identify image file <_io.BytesIO object at 0x7f0a6ecb1780> ``` and also further down ``` odoo.exceptions.UserError: ('This file could not be decoded as an image file. Please try with a different file.', '') ``` Examples of such files are CAD files (mimetype: image/vnd.dwg) For a list of all mimetypes starting with "image/" see: https://www.iana.org/assignments/media-types/media-types.xhtml#image

Change in the permissions for DMS Access Groups: - Not every user can create new access groups, but only dms_users. - DMS managers (not admin users) can manage every access group - Add tests After this change: - the base user has read only access - the group_dms_user can create, and can write and unlink their own groups - the group_dms_manager can do everything on every group.

… the files. TT43563

Currently translated at 94.3% (319 of 338 strings) Translation: dms-15.0/dms-15.0-dms Translate-URL: https://translation.odoo-community.org/projects/dms-15-0/dms-15-0-dms/es/

Currently translated at 70.0% (238 of 340 strings) Translation: dms-16.0/dms-16.0-dms Translate-URL: https://translation.odoo-community.org/projects/dms-16-0/dms-16-0-dms/pt_BR/

Currently translated at 75.5% (257 of 340 strings) Translation: dms-16.0/dms-16.0-dms Translate-URL: https://translation.odoo-community.org/projects/dms-16-0/dms-16-0-dms/pt_BR/

Currently translated at 95.8% (326 of 340 strings) Translation: dms-16.0/dms-16.0-dms Translate-URL: https://translation.odoo-community.org/projects/dms-16-0/dms-16-0-dms/pt_BR/

Currently translated at 96.1% (327 of 340 strings) Translation: dms-16.0/dms-16.0-dms Translate-URL: https://translation.odoo-community.org/projects/dms-16-0/dms-16-0-dms/pt_BR/

Currently translated at 16.7% (57 of 340 strings) Translation: dms-16.0/dms-16.0-dms Translate-URL: https://translation.odoo-community.org/projects/dms-16-0/dms-16-0-dms/it/

Currently translated at 100.0% (340 of 340 strings) Translation: dms-16.0/dms-16.0-dms Translate-URL: https://translation.odoo-community.org/projects/dms-16-0/dms-16-0-dms/es/

16.0 migration added css to remove padding from dms directory kanban records. Inadvertently, it removed padding from *all* kanban view records in odoo. This commit fixes it by removing the problematic css. Instead, padding is removed only from directory kanban view records, in a manner similar to what file_kanban.scss does for file kanban view. Fixes OCA#271

Currently translated at 100.0% (340 of 340 strings) Translation: dms-16.0/dms-16.0-dms Translate-URL: https://translation.odoo-community.org/projects/dms-16-0/dms-16-0-dms/it/

TT46388 [FIX] dms: Set the correct parent_id of directories in searchpanel If the parent directory is not in all the records we should not set parent_id because the user does not have access to parent. TT46388 [FIX] dms: Avoid error when filtering in files If we filter on files (for example by name) we should not apply kwargs search_domain because we would be incorrectly filtering the directories by name, and we should always list them all. TT46903

… (similar to v15) In the migration to 16.0 this behavior was removed by mistake and was only done in directories OCA@05f7c67#diff-1bb531d306f9014026b38b47879cd2cc7bcb1deaebb7466327f4483a0a459fc3R25

Currently translated at 96.4% (328 of 340 strings) Translation: dms-16.0/dms-16.0-dms Translate-URL: https://translation.odoo-community.org/projects/dms-16-0/dms-16-0-dms/pt_BR/

Currently translated at 100.0% (341 of 341 strings) Translation: dms-16.0/dms-16.0-dms Translate-URL: https://translation.odoo-community.org/projects/dms-16-0/dms-16-0-dms/es/

Currently translated at 100.0% (341 of 341 strings) Translation: dms-16.0/dms-16.0-dms Translate-URL: https://translation.odoo-community.org/projects/dms-16-0/dms-16-0-dms/it/

… to Upload button Example use case: - Go to Documents > Files menu. - Select a directory in search_panel (or from the Files smart-button of a directory). - Click on the "Upload" button - The file has been successfully added to the directory

Use case when clicking on smartbutton Files in a directory: - Only files in that directory or subdirectories are shown. - Only directory and child subdirectories are displayed in search panel. - Directory is auto-selected in search panel. Use case when clicking on smartbutton Subdirectories in a directory: - Only directories in that directory or subdirectories are displayed. - Directory is auto-selected in search panel.

Changes done: - Change setup() to setUpClass() - Add BaseCommon - Remove multi_users decorator (not used) - Remove _setup_test_data and _load from common (not used) - Change DirectoryMailTestCase (extends from StorageDatabaseBaseCase) - Add @mute_logger to skip unnecessary unlink logs

Currently translated at 100.0% (340 of 340 strings) Translation: dms-16.0/dms-16.0-dms Translate-URL: https://translation.odoo-community.org/projects/dms-16-0/dms-16-0-dms/it/

TT46804

In the uninstall process of dms, checks were made that prevented the removal of fields and models being deleted, also causing the dms_file and dms_directory tables to continue to exist.

…ries and Files) To avoid inconsistency with the text displayed when clicking on the button, change display_name of the action to directory name. TT48180

…nfusion When using searchpanel and there is no default_order, records obtained have no defined order (search_read without order). TT48180

…an view TT48648

TT48180

… kanban view.

…warning of 2 fields with the same string.

…ssage

…ion' permission Extra changes: Replace Share buttons with actions Steps to reproduce: - Go to Settings > Users & Companies > Users and create a user only with Documents > Manager permission. (User must not have the Extra Rights > Contact Creation permission). - Go to Documents and go into a directory form view and click on "Share" button. - An access error is displayed

Commits on Jul 26, 2024

[MIG] DMS: Migration to 17.0

tva-subteno-it committed Jul 26, 2024

Configuration menu

View commit details

Copy full SHA for 0ffaf96

Browse repository at this point

Copy the full SHA

0ffaf96 View commit details

Browse the repository at this point in the history

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] DMS : Migration to 17.0 #323

[17.0][MIG] DMS : Migration to 17.0 #323

Commits on Jun 7, 2024

Commits on Jun 20, 2024

Commits on Jul 26, 2024