Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] product_contract: fixes the visibility of the is_contract field in the sales order form #987

Merged
merged 1 commit into from
Sep 20, 2023
Merged

[14.0][FIX] product_contract: fixes the visibility of the is_contract field in the sales order form #987

merged 1 commit into from
Sep 20, 2023

Conversation

marcelsavegnago
Copy link
Member

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @sbejaoui,
some modules you are maintaining are being modified, check this out!

@marcelsavegnago
Copy link
Member Author

ping @douglascstd @augustodinizl @aug1804 @kaynnan

douglascstd
douglascstd approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@douglascstd douglascstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[FUNCTIONAL TESTE] APPROVED

From:
image
image

TO:
image
image

rousseldenis
rousseldenis requested changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@marcelsavegnago
Copy link
Member Author

ping @sbejaoui @pedrobaeza

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-987-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 83e3bff into OCA:14.0 Sep 20, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1f1f0e6. Thanks a lot for contributing to OCA. ❤️

@marcelsavegnago marcelsavegnago deleted the 14.0-fix-product_contract-fix-form branch September 21, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@douglascstd douglascstd douglascstd approved these changes

Assignees
No one assigned
Labels
approved enhancement merged 🎉 needs review ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marcelsavegnago @OCA-git-bot @pedrobaeza @rousseldenis @douglascstd