[17.0][WIP][MIG] connector_jira_tempo_base: Migration to 17.0 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilvioC2C
changed the title
SilvioC2C
force-pushed
the
17.0-mig-connector_jira_tempo_base
branch
from
784a4a0
to
0a5093d
Compare
depend on web-api/webservice to communicate with the tempo API. Depends on OCA/web-api#40 add backend records for the different servers used by tempo
SilvioC2C
force-pushed
the
17.0-mig-connector_jira_tempo_base
branch
from
0a5093d
to
548224d
Compare
yankinmax
reviewed
Sep 3, 2024
| @@ -11,8 +12,8 @@ | |||
| >https://{jira-cloud-instance-name}.atlassian.net/plugins/servlet/ac/io.tempo.jira/oauth-authorize/</field> | |||
| <field name="oauth2_token_url">https://api.tempo.io/oauth/token/</field> | |||
| <field name="oauth2_flow">web_application</field> | |||
| <field name="oauth2_clientid_env_default">Fill with Server Env</field> | |||
| <field name="oauth2_client_secret_env_default">Fill with Server Env</field> | |||
| <field name="x_oauth2_clientid_env_default">Fill with Server Env</field> | |||
There was a problem hiding this comment.
why renaming oauth2_clientid_env_default to x_*?
There was a problem hiding this comment.
To match the automatic name given to the field by module server_environment
yankinmax
approved these changes
Sep 4, 2024
yankinmax
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration based on top of #108