[16.0][FIX] account_mass_reconcile: New environment is initialized when ... #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiobstoj
force-pushed
the
16.0-fix-account_mass_reconcile-run_reconcile
branch
from
150f6e5
to
3e1cb11
Compare
sergiobstoj
changed the title
sergiobstoj
changed the title
…en the for loop begins so as not to lose the record of last reconciled items by having "commit_every" > 0 configured
sergiobstoj
force-pushed
the
16.0-fix-account_mass_reconcile-run_reconcile
branch
from
3e1cb11
to
1fde2d1
Compare
aritzolea
approved these changes
Sep 4, 2024
|
/ocabot merge patch |
|
Sorry @sergiocorato you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
|
@AaronHForgeFlow is it possible to merge this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New environment is initialized when the for loop begins so as not to lose the record of last reconciled items by having "commit_every" > 0 configured.
When having
reconciliation_commit_everyconfigured as >0There are no records linked on Display items reconciled on the last run
With this fix, having same config (pictures from this PR Runboat):
We can see the las reconciled items:
