Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] account_mass_reconcile: New environment is initialized when ... #686

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

sergiobstoj
Copy link
Member

@sergiobstoj sergiobstoj commented Aug 26, 2024

New environment is initialized when the for loop begins so as not to lose the record of last reconciled items by having "commit_every" > 0 configured.

When having reconciliation_commit_every configured as >0
image

There are no records linked on Display items reconciled on the last run
image

With this fix, having same config (pictures from this PR Runboat):
image

We can see the las reconciled items:
image

@sergiobstoj sergiobstoj reopened this Sep 4, 2024
@sergiobstoj sergiobstoj force-pushed the 16.0-fix-account_mass_reconcile-run_reconcile branch from 150f6e5 to 3e1cb11 Compare September 4, 2024 12:05
@sergiobstoj sergiobstoj changed the title [16.0][FIX] account_mass_reconcile: Add a commit for the original env… [16.0][FIX] account_mass_reconcile: New environment is initialized when Sep 4, 2024
@sergiobstoj sergiobstoj changed the title [16.0][FIX] account_mass_reconcile: New environment is initialized when [16.0][FIX] account_mass_reconcile: New environment is initialized when ... Sep 4, 2024
…en the for loop begins so as not to lose the record of last reconciled items by having "commit_every" > 0 configured
@sergiobstoj sergiobstoj force-pushed the 16.0-fix-account_mass_reconcile-run_reconcile branch from 3e1cb11 to 1fde2d1 Compare September 4, 2024 12:11
Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergiobstoj sergiobstoj marked this pull request as ready for review September 5, 2024 07:22
@sergiobstoj sergiobstoj marked this pull request as draft September 5, 2024 09:01
@sergiobstoj sergiobstoj marked this pull request as ready for review September 6, 2024 07:40
@sergiocorato
Copy link

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Sorry @sergiocorato you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@sergiocorato
Copy link

@AaronHForgeFlow is it possible to merge this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants