Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][FIX] account_reconciliation_widget: m2x record keyboard navigation #598

Conversation

chienandalu
Copy link
Member

@chienandalu chienandalu commented Oct 4, 2023

We couldn't use our direction keys to go down the record list on a many2one field as the navigation events are propagated from the field it self and go up to the widget where a navigation through the reconcile keys is expected.

Both behaviors are preserved.

Peek 04-10-2023 15-45

cc @Tecnativa TT45219

please review @pedrobaeza @victoralmau

We couldn't  use our direction keys to go down the record list on a
many2one field as the navigation events are propagated from the field it
self and go up to the widget where a navigation through the reconcile
keys is expected.

Both behaviors are preserved.

TT45219
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Tested on runboat

@pedrobaeza pedrobaeza added this to the 15.0 milestone Oct 4, 2023
@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-598-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f247244 into OCA:15.0 Oct 5, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9f4bcb7. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-fix-account_reconciliation_widget-m2o-keys branch October 5, 2023 06:38
@sergio-teruel
Copy link
Contributor

Great!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants