Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [IMP] account_reconcile_oca #587

Merged
merged 3 commits into from
Sep 11, 2023
Merged

[16.0] [IMP] account_reconcile_oca #587

merged 3 commits into from
Sep 11, 2023

Conversation

etobella
Copy link
Member

@etobella etobella commented Sep 6, 2023

Fix #586
Implements #572

@pedrobaeza pedrobaeza added this to the 16.0 milestone Sep 7, 2023
@etobella
Copy link
Member Author

etobella commented Sep 7, 2023

@nagybal Can you test it please 🙏 ?

@nagybal
Copy link

nagybal commented Sep 8, 2023

I can confirm, the currency shows OK.

The translations are better now.

  • Unreconcile OK
  • "Reset reconciliation" is better than "Undo reconciliation". (If it is not too much coding, I would add a mouseover-hovering text box with clarification)

@pedrobaeza
Copy link
Member

Wasn't finally "Unreconcile" the selected word?

@nagybal
Copy link

nagybal commented Sep 8, 2023

About showing the right currency I did find a similar minor display issue, where the UoM of the currency is incorrect:
If You issue an invoice there is a specific exchange rate, one month later of course it is not the same exchange rate. The validation tool is smart enough and is adding the "976000 Exchange rate gains on exchange and valuation". This working as expected but as you see, its adding the difference again in the wrong currency. The amount is correct by the way:
Screenshot 2023-09-08 at 16 19 12

I did find a bug as well. Every time I click the second line. Marked with blue on the screenshot. The reconciliation tool adds an other line. Why it is happening I do not understand.
Screenshot 2023-09-08 at 16 29 24

@nagybal
Copy link

nagybal commented Sep 9, 2023

I was able to reproduce this on runboat as well
Screenshot 2023-09-09 at 6 59 09

And the strange extra lines on click
Screenshot 2023-09-09 at 6 59 26

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-587-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 46aa2e6. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 94e1034 into OCA:16.0 Sep 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants