[17.0][MIG] account_chart_update: Migration to 17.0 #1989

victoralmau · 2024-12-13T08:37:46Z

Supersedes #1888

Migration to 17.0

Changes done:

Purge translations
Squash administrative commits
Change name_get to _compute_display_name
Change attrs to invisible/required
Adapt to the new account.chart.template system without records
Remove recreate_xml_ids fields (It is always necessary for them to have the expected xml_id)
Adapt tests
Improve similar methods to reduce code

Please @pedrobaeza can you review it?

giarve

these 3 diffs always appear on runbot even after applying the wizard twice with the same chart. I do not know if you want to take a look. Everything else works good.

It is true though that not being able to edit the chart template from inside odoo is less convenient (to change the number of padding zeroes for example).

account_chart_update/wizard/wizard_chart_update.py

giarve · 2024-12-14T15:27:19Z

account_chart_update/wizard/wizard_chart_update.py

-        string="Account template",
-        required=True,
-    )
+    xml_id = fields.Char()


only showing the xml id makes it harder to see new accounts and their name.

However, this is just an improvement so not requesting anything here. Also might be enough in 99% of the cases.

victoralmau · 2024-12-17T12:17:40Z

these 3 diffs always appear on runbot even after applying the wizard twice with the same chart. I do not know if you want to take a look. Everything else works good.

It is true though that not being able to edit the chart template from inside odoo is less convenient (to change the number of padding zeroes for example).

Thanks, checked and fixed.

DavidJForgeFlow

Code LGTM! Seems to be working fine also 👍

[FIX]: Changed types to orm.Model, orm.TransientModel and orm.AbstractModel. [FIX]: Fix deletion method for some fields of objects. [FIX]: Contributions have been written in the standard format of the community. [FIX]: Changes in the form to work as a real wizard. [FIX]: Remove 'init_xml' keys, because it's no longer needed in v7. [FIX]: Rename 'demo_xml' key to the new standard 'demo'. [FIX]: Change imports calls. [FIX]: Remove __author__ variables in files, because authors are put on manifest file (__openerp__.py). [FIX]: Update view definitions to version 7.0 [FIX]: Rename variables to OpenERP standard. [FIX]: Increased compatibility with standard PEP8. [IMP]: User Invitu add the method call _reopen to keep open the wizard. [MRG]: User Invitu add frech language.

…permission.

…ntation

…ing. [FIX] account_chart_update: Adapted to work with inherited account chart templates. [FIX] account_chart_update: Remove required=True for chart_template_id on DB and put on screen to avoid error when removing chart templates. [FIX] account_chart_update: Change method to compare taxes of fiscal positions to match with the one comparing taxes. [FIX] account_chart_update: Change method to compare accounts of fiscal positions to match with the one comparing accounts. [IMP] account_chart_update: Wizard now shows in tree view modification notes. [IMP] account_chart_update: For new data to be created, it is marked on notes the reason for the creation (just for clarity). [IMP] account_chart_update: Tabs for operations that are not going to be performed are hidden. [IMP] account_chart_update: Some PEP8 here and there. [IMP] account_chart_update: Enhance a little the mapping searches (there's more room to improve). [IMP] account_chart_update: Now it takes into account name and description for mapping taxes.

* Move out of unported * Set account_chart_update installable * value_reference of ir.property is a char * Use get_by_record method of ir.property * number digits is returned before assignment in case of property exist but account not * product_obj isn't used

* search on code first to match tax codes The tax code code should be more discriminant that the tax code name. * compare more fields in tax codes * deletion of tax codes removed from templates For tax codes, it make sense to propose deletion, since tax codes are normally defined by the tax authority and the user does not customize them. * update accounts on taxes even if an update of the account was not requested Useful when the chart of taxes changes but the chart of account need not be updated. * depth-first search of tax codes This helps creating parents before children. * compare more fields in taxes * add active field on tax code Deactivate tax codes which are not in the template. * deactivate taxes that are not in the template * multi-company criteria for taxes * avoid inserting duplicates in presence of inactive taxes or tax codes

* Fix calculated field when showing inactives + add field to view * Migrated to new API. * Provided hooks for detecting changes and for adding update/create values. * Purge dead error detection code (not applying). * Use global mapping dictionaries stored on class instead of passing arguments down to top and viceversa. * Number fields computed by a function field instead of being computed by hand. * Use recordsets as indexes instead of ids to avoid repetitive browses. * Re-enable local cache variables * README + authors

* Set updated taxes as active * Check parent_id field in '_is_different_tax' method * PEP8 * Spanish translation

…cache. Closes OCA#240

As there's a constraint that forbids to write the code of the account if it has moves, we delete the corresponding entry on update only, because the method that prepares the values is the same for new and existing accounts.

* Process price_include field * Detect change in price_include field

- New-style license headers. - Remove .pot file. - Remove tax codes stuff, now removed from v9. - Refactor methods for search, create, update, delete. Now they are smaller, fitter, happier, more productive. - Only update fields that have any kind of change on any updated record. - Place the wizard in the configuration page, instead of its own menu item. - Display amount of disabled taxes at ending page.

…tions + clean authors As this module has been written from scratch with a totally different technique, I clean the list and update copyrights.

…ansactionCase - Depending on l10n_generic_coa is the lazy option for not putting proper initialization data on the test, and it also couples the tests to the external module changes. - Switch to TransactionCase, for populating once the company, CoA, etc. - Speed up a bit the tests, removing superflual mail operations. account_chart_update 16.0.2.0.2

Currently translated at 100.0% (137 of 137 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_chart_update Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_chart_update/es/ [UPD] README.rst

Use tax record as key in tax_template_ref dict because in odoo/account/models/chart_template.py line 959, the given key on dict reading is a tax record and not a simple id. [BOT] post-merge updates

Currently translated at 100.0% (137 of 137 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_chart_update Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_chart_update/es_AR/

Currently translated at 94.1% (129 of 137 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_chart_update Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_chart_update/pt_BR/

Currently translated at 100.0% (137 of 137 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_chart_update Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_chart_update/sv/

Currently translated at 100.0% (137 of 137 strings) Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_chart_update Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_chart_update/pt_BR/

[BOT] post-merge updates

MT-7597

… and ditch decorators as mentioned in code review [BOT] post-merge updates

LoisRForgeFlow

Functional review 👍

pedrobaeza · 2024-12-24T12:44:10Z

/ocabot migration account_chart_update

pedrobaeza

Several things:

Is there any possibility to only load in the "Chart template" dropdown those that are already installed?
When a tax group is not present (because for example is added in the last update), you get an error. You can force to happen trying to load Spanish taxes on generic CoA for example.

victoralmau · 2025-01-07T12:15:47Z

Several things:

* Is there any possibility to only load in the "Chart template" dropdown those that are already installed?

* When a tax group is not present (because for example is added in the last update), you get an error. You can force to happen trying to load Spanish taxes on generic CoA for example.

Changes done. The test error related to _logger I don't understand, any idea?

victoralmau · 2025-01-08T08:25:12Z

The test error is finally fixed.

syci · 2025-01-10T08:03:39Z

The wizard does not take into account the selected language.

https://github.com/Tecnativa/account-financial-tools/blob/b20ed9d7be75352d92041b2478c4af557fa769d4/account_chart_update/wizard/wizard_chart_update.py#L767

In a plan update the name of the taxes always appears in English.

With this change it works correctly.

    def _load_data(self, model, data):
        """Process similar to the one in chart template."""
        template = self.env["account.chart.template"].with_context(
            default_company_id=self.company_id.id,
            allowed_company_ids=[self.company_id.id],
            tracking_disable=True,
            delay_account_group_sync=True,
            lang=self.lang,
        )

Changes done: - Purge translations - Squash administrative commits - Change name_get to _compute_display_name - Change attrs to invisible/required - Adapt to the new account.chart.template system without records - Remove recreate_xml_ids fields (It is always necessary for them to have the expected xml_id) TT49275

victoralmau · 2025-01-10T09:51:38Z

The wizard does not take into account the selected language.

https://github.com/Tecnativa/account-financial-tools/blob/b20ed9d7be75352d92041b2478c4af557fa769d4/account_chart_update/wizard/wizard_chart_update.py#L767

In a plan update the name of the taxes always appears in English.

With this change it works correctly.
    def _load_data(self, model, data):
        """Process similar to the one in chart template."""
        template = self.env["account.chart.template"].with_context(
            default_company_id=self.company_id.id,
            allowed_company_ids=[self.company_id.id],
            tracking_disable=True,
            delay_account_group_sync=True,
            lang=self.lang,
        )

Thanks for the comment, it has been solved so that the language is correctly taken into account (the suggestion you proposed was not enough).

victoralmau mentioned this pull request Dec 13, 2024

[17.0][MIG] account_chart_update #1888

Closed

victoralmau force-pushed the 17.0-mig-account_chart_update branch 2 times, most recently from 7eca605 to d6fa9c0 Compare December 13, 2024 17:20

victoralmau marked this pull request as ready for review December 13, 2024 17:24

giarve approved these changes Dec 14, 2024

View reviewed changes

victoralmau force-pushed the 17.0-mig-account_chart_update branch from d6fa9c0 to ae497db Compare December 17, 2024 12:12

giarve approved these changes Dec 17, 2024

View reviewed changes

DavidJForgeFlow approved these changes Dec 19, 2024

View reviewed changes

OCA-git-bot added the approved label Dec 19, 2024

percevaq and others added 20 commits December 19, 2024 12:20

[IMP] account_chart_update: Menu path to avoid needing multi-company …

5f6c65e

…permission.

[IMP] small improvement : calling reopen method in action_init + inde…

2460f8c

…ntation

FIX: wrong dict passed in _update_accounts

8452795

[IMP] attempt to match tax code on code if no match on name was found

7b21451

Set all addons to uninstallable

1d7e911

[FIX+IMP] account_chart_update: Several things

75baa48

* Set updated taxes as active * Check parent_id field in '_is_different_tax' method * PEP8 * Spanish translation

[FIX] account_chart_update: Call mapping function instead of removed …

215a83e

…cache. Closes OCA#240

[FIX][account-financial-tools] depends key is duplicated

9f62a78

[FIX] account_chart_update: Don't write code on account update

64cc010

As there's a constraint that forbids to write the code of the account if it has moves, we delete the corresponding entry on update only, because the method that prepares the values is the same for new and existing accounts.

[FIX] Include acc templates from parent CoA templates

7cb40cc

[FIX] account_chart_update:

62652ee

* Process price_include field * Detect change in price_include field

[FIX+IMP] account_chart_update: Fix fiscal position mapping + transla…

8acc6ab

…tions + clean authors As this module has been written from scratch with a totally different technique, I clean the list and update copyrights.

[MIG] account_chart_update: Migration to 10.0

9a75bb8

[FIX] account_chart_update: Fetch account code digits correctly

f815aa5

pedrobaeza and others added 14 commits December 19, 2024 12:20

[FIX] wizard_chart_update.py

2bc259c

Use tax record as key in tax_template_ref dict because in odoo/account/models/chart_template.py line 959, the given key on dict reading is a tax record and not a simple id. [BOT] post-merge updates

[16.0][FIX] account_chart_update: prevent malformed xmlid during update

0708e22

[BOT] post-merge updates

[FIX] account_chart_update: fix _update_accounts when creating account

8deae90

[BOT] post-merge updates

[16.0] account_chart_update - separate common data from actual tests

cc7b35f

MT-7597

[16.0][ADD] account_chart_update_multilang

2abbe09

MT-7597

[FIX] account_chart_update_multilang: hide default language in wizard…

ba7a91b

… and ditch decorators as mentioned in code review [BOT] post-merge updates

[IMP] account_chart_update: pre-commit auto fixes

74936d8

[MIG] account_chart_update: Migration to 17.0

04d4dc1

victoralmau force-pushed the 17.0-mig-account_chart_update branch from ae497db to 49d121b Compare December 19, 2024 11:20

DavidJForgeFlow mentioned this pull request Dec 19, 2024

[17.0][MIG] account_chart_update_l10n_eu_oss #1994

Open

LoisRForgeFlow approved these changes Dec 23, 2024

View reviewed changes

OCA-git-bot added this to the 17.0 milestone Dec 24, 2024

OCA-git-bot mentioned this pull request Dec 24, 2024

Migration to version 17.0 #1774

Open

33 tasks

pedrobaeza requested changes Dec 24, 2024

View reviewed changes

OCA-git-bot removed the approved label Dec 24, 2024

victoralmau force-pushed the 17.0-mig-account_chart_update branch from 49d121b to 313753c Compare January 7, 2025 12:03

victoralmau force-pushed the 17.0-mig-account_chart_update branch from 313753c to b20ed9d Compare January 8, 2025 08:19

victoralmau force-pushed the 17.0-mig-account_chart_update branch from b20ed9d to 4346793 Compare January 10, 2025 09:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] account_chart_update: Migration to 17.0 #1989

[17.0][MIG] account_chart_update: Migration to 17.0 #1989

victoralmau commented Dec 13, 2024 •

edited

Loading

giarve left a comment

giarve Dec 14, 2024

victoralmau commented Dec 17, 2024

DavidJForgeFlow left a comment

LoisRForgeFlow left a comment

pedrobaeza commented Dec 24, 2024

pedrobaeza left a comment

victoralmau commented Jan 7, 2025

victoralmau commented Jan 8, 2025

syci commented Jan 10, 2025

victoralmau commented Jan 10, 2025

[17.0][MIG] account_chart_update: Migration to 17.0 #1989

Are you sure you want to change the base?

[17.0][MIG] account_chart_update: Migration to 17.0 #1989

Conversation

victoralmau commented Dec 13, 2024 • edited Loading

giarve left a comment

Choose a reason for hiding this comment

giarve Dec 14, 2024

Choose a reason for hiding this comment

victoralmau commented Dec 17, 2024

DavidJForgeFlow left a comment

Choose a reason for hiding this comment

LoisRForgeFlow left a comment

Choose a reason for hiding this comment

pedrobaeza commented Dec 24, 2024

pedrobaeza left a comment

Choose a reason for hiding this comment

victoralmau commented Jan 7, 2025

victoralmau commented Jan 8, 2025

syci commented Jan 10, 2025

victoralmau commented Jan 10, 2025

victoralmau commented Dec 13, 2024 •

edited

Loading