[FIX] account_move_template: Fixed invoice_tax_id error while generat…

…ing journal entries from template
OCA · Sep 2, 2024 · 0618c58 · 0618c58
1 parent e0fb9f0
commit 0618c58
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 10 deletions.
diff --git a/account_move_template/models/account_move_template.py b/account_move_template/models/account_move_template.py
@@ -161,10 +161,6 @@ class AccountMoveTemplateLine(models.Model):
         string="Payment Terms",
         help="Used to compute the due date of the journal item.",
     )
-    is_refund = fields.Boolean(
-        default=False,
-        string="Is a refund?",
-    )
     tax_repartition_line_id = fields.Many2one(
         "account.tax.repartition.line",
         string="Tax Repartition Line",
@@ -179,10 +175,10 @@ class AccountMoveTemplateLine(models.Model):
         help="When amount is negative, use this account instead",
     )
 
-    @api.depends("is_refund", "account_id", "tax_line_id")
+    @api.depends("account_id", "tax_line_id")
     def _compute_tax_repartition_line_id(self):
         for record in self.filtered(lambda x: x.account_id and x.tax_line_id):
-            tax_repartition = "refund_tax_id" if record.is_refund else "invoice_tax_id"
+            tax_repartition = "tax_id"
             record.tax_repartition_line_id = self.env[
                 "account.tax.repartition.line"
             ].search(

diff --git a/account_move_template/view/account_move_template.xml b/account_move_template/view/account_move_template.xml
@@ -51,7 +51,6 @@
                             />
 
                             <field name="payment_term_id" />
-                            <field name="is_refund" />
                             <field name="tax_line_id" />
                             <field
                                 name="tax_repartition_line_id"

diff --git a/account_move_template/wizard/account_move_template_run.py b/account_move_template/wizard/account_move_template_run.py
@@ -61,7 +61,6 @@ def _prepare_wizard_line(self, tmpl_line):
             "analytic_distribution": tmpl_line.analytic_distribution,
             "note": tmpl_line.note,
             "payment_term_id": tmpl_line.payment_term_id.id or False,
-            "is_refund": tmpl_line.is_refund,
             "tax_repartition_line_id": tmpl_line.tax_repartition_line_id.id or False,
         }
         return vals
@@ -225,7 +224,7 @@ def _prepare_move_line(self, line, amount):
         }
         if line.tax_ids:
             values["tax_ids"] = [Command.set(line.tax_ids.ids)]
-            tax_repartition = "refund_tax_id" if line.is_refund else "invoice_tax_id"
+            tax_repartition = "tax_id"
             atrl_ids = self.env["account.tax.repartition.line"].search(
                 [
                     (tax_repartition, "in", line.tax_ids.ids),
@@ -285,7 +284,6 @@ class AccountMoveTemplateLineRun(models.TransientModel):
     )
     amount = fields.Monetary(required=True, currency_field="company_currency_id")
     note = fields.Char(readonly=True)
-    is_refund = fields.Boolean(string="Is a refund?", readonly=True)
     tax_repartition_line_id = fields.Many2one(
         "account.tax.repartition.line",
         string="Tax Repartition Line",