[16.0][FIX] account_budget_oca: fix operation error _compute_practica…

[polqubiq]

When an Analytic Account is selected and the Period has not been set yet, the following error appears:

  File "/opt/odoo/auto/addons/account_budget_oca/models/account_budget.py", line 155, in _compute_practical_amount
    self.env.cr.execute(
  File "/opt/odoo/custom/src/odoo/odoo/sql_db.py", line 321, in execute
    res = self._obj.execute(query, params)
psycopg2.errors.UndefinedFunction: operator does not exist: date >= boolean
LINE 5:                         AND (date between false
                                          ^
HINT:  No operator matches the given name and argument types. You might need to add explicit type casts.


The above server error caused the following client error:
null

The problem is that the query is comparing incompatible operators (date and boolean, because we have not selected date yet):

                self.env.cr.execute(
                    """
                    SELECT SUM(amount)
                    FROM account_analytic_line
                    WHERE account_id=%s
                        AND (date between %s
                        AND %s)
                        AND general_account_id=ANY(%s)""",
                    (line.analytic_account_id.id, date_from, date_to, acc_ids),
                )

[polqubiq]

@pedrobaeza have a look at this small FIX.

Thanks!

[pedrobaeza]

Sorry, but I don't use this module.

[polqubiq]

Sorry, but I don't use this module.

And who does? Maybe @AaronHForgeFlow

[pedrobaeza]

Check commit history or maintainers.

[polqubiq]

Check commit history or maintainers.

I understand. @oihane do you know something about this?

QubiQ@42af671#diff-576f4b2b41e053ce6e015b8c4f37ccfcc7c21be4093e13230aa6557f11e379e0R148

[oihane]

LGTM

[polqubiq]

LGTM

Thanks @oihane !

[polqubiq]

@alvarorib could you review this small fix please?

[giarve]

Makes sense as if you fill the first date, supposedly right now does not allow setting the second date without the error

[polqubiq]

Makes sense as if you fill the first date, supposedly right now does not allow setting the second date without the error

Thanks, @giarve do you know who is responsable for merging the PR?

[giarve]

Makes sense as if you fill the first date, supposedly right now does not allow setting the second date without the error

Thanks, @giarve do you know who is responsable for merging the PR?

I do not know, sorry. It is not a very active repository.

[pedrobaeza]

Trusting current reviews:

/ocabot merge patch

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-76-by-pedrobaeza-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 11de32d. Thanks a lot for contributing to OCA. ❤️