Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][mig] analytic_tag_dimension_enhanced #498

Closed
wants to merge 23 commits into from
Closed

[15.0][mig] analytic_tag_dimension_enhanced #498

wants to merge 23 commits into from

Conversation

TheerayutEncoder
Copy link

Standard migration 👍

@TheerayutEncoder TheerayutEncoder force-pushed the 15.0-mig-analytic_tag_dimension_enhanced branch 2 times, most recently from adc905d to 28677e5 Compare November 23, 2022 07:11
@TheerayutEncoder
Copy link
Author

@newtratip @Saran440
Can you help review ?
Thanks.

@ps-tubtim
Copy link
Member

@TheerayutEncoder Please separate the commits following https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0 and add you to CONTRIBUTORS.rst.

@Saran440 Saran440 force-pushed the 15.0-mig-analytic_tag_dimension_enhanced branch from 0887de5 to 224c7a2 Compare March 3, 2023 04:02
Saran440
Saran440 approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No code change 👍

@rafaelbn rafaelbn added this to the 15.0 milestone Mar 9, 2023
@rafaelbn
Copy link
Member

rafaelbn commented Mar 9, 2023

/ocabot migration analytic_tag_dimension_enhanced

@OCA-git-bot OCA-git-bot mentioned this pull request Mar 9, 2023
Closed
21 tasks
@Saran440 Saran440 force-pushed the 15.0-mig-analytic_tag_dimension_enhanced branch from 8fdc74b to 4d111a3 Compare May 12, 2023 08:31
@Saran440
Copy link
Member

I enhanced this module for easy some module don't need required
Selection_016

In case, we need required analytic tags somewhere not all.
This commit will can exclude filter for not required analytic tags

@Saran440 Saran440 force-pushed the 15.0-mig-analytic_tag_dimension_enhanced branch 2 times, most recently from 489348b to af899ac Compare June 27, 2023 03:19
kittiu and others added 16 commits September 26, 2023 14:05
@kittiu @Saran440
[12.0][ADD] account_tag_dimension_enhanced
a7d2698
@oca-travis @Saran440
[UPD] Update analytic_tag_dimension_enhanced.pot
474d656
@OCA-git-bot @Saran440
[UPD] README.rst
abe92ce
@pedrobaeza @Saran440
[FIX+IMP] analytic_tag_dimension_enhanced: Adapt tests
b9e2008 
- Reuse base tests
- Fix test order for not having a commit in between.
@Saran440
[IMP] analytic_tag_dimension_enhanced: black, isort, prettier
5131352
@Saran440
[13.0][MIG] analytic_tag_dimension_enhanced
c9ee18a
@kittiu @Saran440
[MIG][FIX] analytic_tag_dimension_enhanced, fix required check
fd9c5cb
@Saran440
[FIX] domain filtered
9b17520
@Saran440
[FIX] Split files analytic.py
3d302e2
@kittiu @Saran440
[IMP] analytic_tag_dimension_enhanced: black, isort, prettier
8c96c25
@kittiu @Saran440
[14.0][MIG] analytic_tag_dimension_enhanced
5dd1c45
@oca-travis @Saran440
[UPD] Update analytic_tag_dimension_enhanced.pot
7622b50
@OCA-git-bot @Saran440
[UPD] README.rst
1683da6
@Saran440
[FIX] update name tag from create tag dimension
e80d8d9
@OCA-git-bot @Saran440
analytic_tag_dimension_enhanced 14.0.1.1.0
440cb5e
@Saran440
[FIX] domain_tag follow line_ids (journal items)
4bd10cb
@Saran440 Saran440 force-pushed the 15.0-mig-analytic_tag_dimension_enhanced branch from cc3b2de to d7c2bf3 Compare September 26, 2023 07:05
ps-tubtim
ps-tubtim approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@ps-tubtim ps-tubtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 28, 2024
@github-actions github-actions bot closed this Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saran440 Saran440 Saran440 approved these changes

@ps-tubtim ps-tubtim ps-tubtim approved these changes

Assignees
No one assigned
Labels
approved needs review ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
8 participants
@TheerayutEncoder @ps-tubtim @rafaelbn @Saran440 @OCA-git-bot @kittiu @oca-travis @pedrobaeza