[15.0][UPD] apriori + analysis + coverage

[MiquelRForgeFlow]

Here it goes.

[legalsylvain]

hum. thanks for this work.

1. do you know why there are such changes between few monthes ?
2. Some changes are annoying. I don't know how to handle the account case (for exemple). Do you have an idea ?

thanks.

regards.

[MiquelRForgeFlow]

1. Hehe. Do you now how many commits odoo have added in those months? First year after new versions is always like this.
2. Don't worry. For account, some scripts will be added in 15.0.1.1 version and maybe some others in 15.0.1.2 folder. Depending of what has changed between them. To know what has changed between them, we will need to manually compare both analysis and detect the difference.

[legalsylvain]

Don't worry.

Hum, I'm not sure : I'm mean,

• the current upgrade.txt file in the folder 15.0.1.1 is a diff of 14.0 and 15.0.1.1
• the current upgrade.txt file in the folder 15.0.1.2 is a diff of 14.0 and 15.0.1.2

AFAIU, the current upgrade.txt file in the folder 15.0.1.2 should be a diff of 15.0.1.1 and 15.0.1.2 (maybe minor).

What do we do ?

Option A) We assume two revision.15.0.1.1 and 15.0.1.2 and we provides script for both "migrations". We have to change the upgrade.txt file 15.0.1.2 to be only the diff between 15.0.1.1 and 15.0.1.2. And we should take care that in the migration, the execution will be the following :

• 15.0.1.1/pre-migration.py
• 15.0.1.2/pre-migration.py
• 15.0.1.1/post-migration.py
• 15.0.1.2/post-migration.py

So, in the pre-migration of the 15.0.1.2 the database is not totally a "15.0.1.1" (15.0.1.1/post-migration.py has not been executed). I faced similar issue when upgrading queue_job. (see : https://github.com/OCA/queue/tree/12.0/queue_job/migrations)

Option B) : we remove all the 15.0.1.1 folder. but it requires to rebase / adapt all the current (#3284) for instance.

CC : @StefanRijnhart, @pedrobaeza : what do you think ?

[pedrobaeza]

Everything should be done directly in 15.0.1.2 and directly the other folder must disappear.

[jcdrubay]

Then does it make sense to keep the name 15.0.1.2, why not only keeping 15.0? or why not simply removing that folder from the path?

[pedrobaeza]

The folder name must always match the latest version

[legalsylvain]

Everything should be done directly in 15.0.1.2 and directly the other folder must disappear.

Well, I'm in favour of this solution (for simplicity). But I'm not very confortable with the fact to say to 15.0 contributors, to add extra work to rebase and recheck diff, and fix some stuff. The work provided here #3287 is important, and it lacks code review. (we should talk about that topic in the next coming soon Openupgrade Strategy meeting).

Then does it make sense to keep the name 15.0.1.2, why not only keeping 15.0? or why not simply removing that folder from the path?

It doesn't work. And it doesn't solve the main problem. (1 folder or two folders)

The folder name must always match the latest version

well, it is possible to have multiple folders, but it's a mess.

[MiquelRForgeFlow]

I adapted the account issue:

[pedrobaeza]

Well, I'm in favour of this solution (for simplicity). But I'm not very confortable with the fact to say to 15.0 contributors, to add extra work to rebase and recheck diff, and fix some stuff. The work provided here #3287 is important, and it lacks code review. (we should talk about that topic in the next coming soon Openupgrade Strategy meeting).

Complain to Odoo, not to us. The work is the same even if the PR is merged: the scripts must be passed to the other folder and recheck the diff. If not, migration may not work.

[MiquelRForgeFlow]

Ready

[MiquelRForgeFlow]

I tested the mail_group scripts in local, I fixed some things, and now it works like a charm :)