Skip to content

Commit

Permalink
Merge pull request #4311 from ralfhandl/dev-validate-markdown-in-buil…
Browse files Browse the repository at this point in the history
…d-src
  • Loading branch information
ralfhandl authored Jan 22, 2025
2 parents e8a0d07 + cde67e1 commit bf9155d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
8 changes: 3 additions & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -171,12 +171,10 @@ To do this locally, please
1. Install [Node.js](https://nodejs.org/)
2. Check out this repo, go to the repo root, and switch to a development branch
3. Execute `npm install` (once, repeat after merging upstream changes)
4. Execute `npm run build-src` after changing `src/oas.md`
5. Open output file `deploy-preview/oas.html` with a browser
4. Execute `npm run build-src` after changing `src/oas.md` (this first executes `npm run validate-markdown`, which can also be run separately)
5. Open output file `deploy-preview/oas.html` with a browser and check your changes

Before creating a pull request or marking a draft pull request as ready for review, please

6. Execute `npm run validate-markdown` and fix any reported problems in `src/oas.md`
Please make sure the markdown validates and builds using the above steps before creating a pull request or marking a draft pull request as ready for review.

## Reviewers

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"license": "Apache-2.0",
"scripts": {
"build": "bash ./scripts/md2html/build.sh",
"build-src": "bash ./scripts/md2html/build-src.sh",
"build-src": "npm run validate-markdown && bash ./scripts/md2html/build-src.sh",
"test": "c8 --100 vitest --watch=false && bash scripts/schema-test-coverage.sh",
"validate-markdown": "npx mdv src/oas.md && npx markdownlint-cli src/oas.md"
},
Expand Down

0 comments on commit bf9155d

Please sign in to comment.