Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NaNs appear in certain cases when using inverse kinematics #39

Open
64-B1T opened this issue Jun 18, 2021 · 1 comment
Open

NaNs appear in certain cases when using inverse kinematics #39

64-B1T opened this issue Jun 18, 2021 · 1 comment

Comments

@64-B1T
Copy link

64-B1T commented Jun 18, 2021

(Python) In certain transforms, IK will fail due to NANs cropping up. This is because of floating point inaccuracies being fed into np.arccos. (For example in MatrixLog6)
E.g. (-1.0000000002) which will return NaN
To fix this, for each np.arccos(x) in the MR code, replace with np.arccos(np.clip(x,-1,1))

@HuanWeng
Copy link
Contributor

Thank you for pointing this out. Looks like you've fixed that in your branch. I will check and fix that in our next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants