Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embroider Support, gjs/gts extraction, hbs`` extraction (etc?) #1

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Embroider Support, gjs/gts extraction, hbs`` extraction (etc?) #1

wants to merge 13 commits into from

Conversation

NullVoxPopuli
Copy link
Owner

@NullVoxPopuli NullVoxPopuli commented Apr 30, 2022 •
edited
Loading

  • Fix everything in Svg optimizations limber#476
  • Convert to non-ember library
  • Re-support broccoli watching in the "discovery" phase
  • switch to pnpm (speed!)
  • add testing capabilities
  • add lots of tests
  • copy discovered svg paths into the outputPath
  • re-support sprite map generation
  • re-add SVGo (svg optimization)
  • clean up commits and prepare for PR

This implementation of the icon optimizer (will):

  • automatically:
    • watch your files (option: appPaths) for changes, and automatically add referenced SVGs to the build output
    • generates a sprite map based on your used SVGs (using the <use> tag
      • The SVGIcon or Icon component should be re-added in v2-addon form (which is kind of still a non-ember library)

Goals:

  • the above
  • be able to use fontawesome's SVGs without ember-fontawesome, using this package: @fortawesome/fontawesome-free

@NullVoxPopuli NullVoxPopuli mentioned this pull request Apr 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NullVoxPopuli