Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Svg optimizations #476

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Svg optimizations #476

wants to merge 1 commit into from

Commits on May 1, 2022

  1. Ditch ember-fontawesome in favor of manual SVG usage 

    Add missing fontawesome dependency

Fontawesome is searching for a package only at the root of the repo, but it wasn't installed there. This behavior is probably wrong, but I need to dig deeper

Apparently, svg-core was introduced in fontawesome v6, and the problem here is is that CI was not blocking PR merges
    @NullVoxPopuli
    NullVoxPopuli committed May 1, 2022
    Configuration menu
    Copy the full SHA
    6f9639f View commit details
    Browse the repository at this point in the history