Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tater guidebooks #130

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Add tater guidebooks #130

merged 5 commits into from
Jun 20, 2024

Conversation

haykam821
Copy link
Contributor

@haykam821 haykam821 commented May 1, 2023

This pull request adds tater guidebooks, which can be used to record and display every block position each tater is placed at within a world.

Tater guidebook UI

@Gegy Gegy self-requested a review June 8, 2023 20:32
Copy link
Member

@Gegy Gegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some small things - sorry for taking so long!

public TypedActionResult<ItemStack> use(World world, PlayerEntity user, Hand hand) {
var stack = user.getStackInHand(hand);

if (!world.isClient() && user.isCreativeLevelTwoOp()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, should the guidebook only be usable by ops? (is it meant to be used by players? at least, viewing it)

@haykam821 haykam821 changed the base branch from 1.19.4 to 1.20.2 December 9, 2023 19:10
@haykam821 haykam821 changed the base branch from 1.20.2 to 1.20.4 June 19, 2024 14:51
@Gegy Gegy merged commit 137edfe into NucleoidMC:1.20.4 Jun 20, 2024
1 check passed
@haykam821 haykam821 deleted the tater-guidebooks branch June 20, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants