Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up build item collection logic #50

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

haykam821
Copy link
Contributor

This pull request extracts the build item collection logic into a separate class while ensuring that each block state is associated with the correct items.

Copy link
Member

@Hugman76 Hugman76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation of a great idea. Just one missing thing IMO, and then we'll be good to go!

@Hugman76 Hugman76 merged commit 8ea4f82 into NucleoidMC:1.20 Sep 3, 2024
1 check passed
@haykam821 haykam821 deleted the build-item-clean-up branch September 3, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants