Fix invalid target framework error for Solution restore #6091
Conversation
martinrrm
changed the title
| @@ -454,6 +454,12 @@ private static IEnumerable<TargetFrameworkInformation> GetTargetFrameworkInforma | |||
| foreach (var item in GetItemByType(items, "TargetFrameworkInformation")) | |||
| { | |||
| var frameworkString = item.GetProperty("TargetFramework"); | |||
| if (frameworkString.Contains(';')) | |||
| { | |||
| var error = RestoreLogMessage.CreateError(NuGetLogCode.NU1001, string.Format(CultureInfo.CurrentCulture, Strings.Error_InvalidTargetFramework, frameworkString)); | |||
There was a problem hiding this comment.
I know this is in draft, and we had chatted about validating the different scenarios.
If we're going to add something like this, I think static graph might need some changes too.
There was a problem hiding this comment.
Thanks for letting me know, I'll make sure I update static graph too
microsoft-github-policy-service
bot
added
Status:No recent activity
|
This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch. |
1 similar comment
|
This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch. |
dotnet-policy-service
bot
removed
the
Status:No recent activity
Bug
Fixes:
Description
PR Checklist