fix: Ommit append option when running in user mode with arguments

Novakov · Nov 30, 2023 · 3b5b5e2 · 3b5b5e2
1 parent 9d2bd75
commit 3b5b5e2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/qemu_runner/layer.py b/src/qemu_runner/layer.py
@@ -234,7 +234,8 @@ def _yield_args():
             yield layer.general.kernel
 
         if layer.general.kernel_cmdline:
-            yield '-append'
+            if not layer.general.mode or layer.general.mode == Mode.System:
+                yield '-append'
             yield layer.general.kernel_cmdline
 
     return list(_yield_args())
diff --git a/tests/test_layer_cmdline.py b/tests/test_layer_cmdline.py
@@ -46,6 +46,10 @@
         Layer(GeneralSettings(engine='my-engine', kernel='abc.elf', kernel_cmdline='a b c')),
         ['my-engine', '-kernel', 'abc.elf', '-append', 'a b c']
     ),
+    (
+        Layer(GeneralSettings(engine='my-engine', kernel='abc.elf', mode=Mode.User, kernel_cmdline='a b c')),
+        ['my-engine', 'abc.elf', 'a b c']
+    ),
     (
         Layer(
             GeneralSettings(engine='my-engine', halted=True, gdb=True, kernel='abc.elf', kernel_cmdline='a b c'),