Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rainbow enchant t3 #989

Closed
wants to merge 6 commits into from

Conversation

j10a1n15
Copy link
Contributor

The book bundle was added, but the enchanted book itself not
image

Copy link
Collaborator

@jani270 jani270 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add it to the correct parent and format the file with the ingame save option again.

items/RAINBOW;3.json Outdated Show resolved Hide resolved
@jani270
Copy link
Collaborator

jani270 commented Sep 24, 2023

Oh and please change your branch to master.

@j10a1n15
Copy link
Contributor Author

j10a1n15 commented Sep 24, 2023

Please add it to the correct parent and format the file with the ingame save option again.

I would love to format it, but I crash when trying to open the ingame editor

java.lang.NullPointerException: Updating screen events
	at io.github.moulberry.notenoughupdates.itemeditor.NEUItemEditor.<init>(NEUItemEditor.java:93)
	at io.github.moulberry.notenoughupdates.NEUOverlay.keyboardInput(NEUOverlay.java:1183)
	at io.github.moulberry.notenoughupdates.listener.RenderListener.onGuiScreenKeyboard(RenderListener.java:1136)```

edit: nvm

@jani270
Copy link
Collaborator

jani270 commented Sep 24, 2023

Oh and please change your branch to master.

.

@j10a1n15
Copy link
Contributor Author

I dont really understand, so I switch my branch to master and then? Do I pr from the master branch or what? Whats the difference?

@jani270
Copy link
Collaborator

jani270 commented Sep 24, 2023

I dont really understand, so I switch my branch to master and then? Do I pr from the master branch or what? Whats the difference?

Items that are new/changed should always be pr'ed into the master branch as the prerelease branch is only active for people who are using any 2.1.1 version. The prerelease branch will be updated after a few changes on the master

@j10a1n15
Copy link
Contributor Author

I see, thank you!

@jani270
Copy link
Collaborator

jani270 commented Sep 25, 2023

Closing in favour of #991

@jani270 jani270 closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants