Fix nosto-js-sdk usage #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timowestnosto
force-pushed
the
nostojs-fixes
branch
2 times, most recently
from
43cd0ce
to
d2eb210
Compare
timowestnosto
force-pushed
the
nostojs-fixes
branch
from
d2eb210
to
daf0ffc
Compare
| @@ -20,6 +20,7 @@ function RecommendationComponentWrapper(props: { | |||
| } | |||
|
|
|||
| function injectCampaigns(data: CampaignData) { | |||
| // @ts-expect-error not defined | |||
| if (!window.nostojs) { | |||
There was a problem hiding this comment.
Can't we use global namespace definition to overcome this and avoid ts-expect-error comment?
There was a problem hiding this comment.
That would make it global, we have the nostojs import from the nosto-js library which should take care of it, but isNostoLoaded() didn't work
There was a problem hiding this comment.
Let's come back to this later. Not a blocker.
manikandan-ravikumar
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.