Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 4.4.1 - Prevent division by zero when the total product tax included in the product is zero (Free items without tax) #361

Merged
merged 5 commits into from
Sep 17, 2024
Merged

Release 4.4.1 - Prevent division by zero when the total product tax included in the product is zero (Free items without tax) #361

merged 5 commits into from
Sep 17, 2024

Conversation

supercid
Copy link
Member

@supercid supercid commented Sep 17, 2024 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Documentation:

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non-existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

@supercid supercid changed the title Prevent division by zero when the total product tax included in the p… Release 4.4.1 - Prevent division by zero when the total product tax included in the product is zero (Free items without tax) Sep 17, 2024
@supercid supercid changed the base branch from develop to master September 17, 2024 14:58
@supercid supercid merged commit b5d96ed into master Sep 17, 2024
6 checks passed
@supercid supercid deleted the division-by-zero-when-tax-is-zero branch September 17, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@churlevski-filip churlevski-filip churlevski-filip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supercid @churlevski-filip