Merge pull request #361 from Nosto/division-by-zero-when-tax-is-zero #399
Annotations
14 warnings
|
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/cache@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Report annotations:
classes/blocks/NostoDefaultTagging.php#L29
The class NostoDefaultTagging has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13.
|
|
Report annotations:
classes/blocks/NostoRecommendationElement.php#L40
Avoid variables with short names like $id. Configured minimum length is 3.
|
|
Report annotations:
classes/helpers/NostoHelperConfig.php#L29
The class NostoHelperConfig has 17 public methods. Consider refactoring NostoHelperConfig to keep number of public methods under 10.
|
|
Report annotations:
classes/helpers/NostoHelperConfig.php#L350
The 'getSkuEnabled()' method which returns a boolean should be named 'is...()' or 'has...()'
|
|
Report annotations:
classes/helpers/NostoHelperConfig.php#L441
The 'getVariationEnabled()' method which returns a boolean should be named 'is...()' or 'has...()'
|
|
Report annotations:
classes/helpers/NostoHelperConfig.php#L459
The 'getVariationTaxRuleEnabled()' method which returns a boolean should be named 'is...()' or 'has...()'
|
|
Report annotations:
classes/helpers/NostoHelperContext.php#L29
The class NostoHelperContext has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13.
|
|
Report annotations:
classes/helpers/NostoHelperContext.php#L32
Avoid excessively long variable names like $backupShopContextStack. Keep variable name length under 20.
|
|
Report annotations:
classes/helpers/NostoHelperController.php#L73
The method resolveObject() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
|
|
Report annotations:
classes/helpers/NostoHelperController.php#L79
Avoid variables with short names like $id. Configured minimum length is 3.
|
|
Set up PHP
Skipping prestissimo, as it does not support Composer . Specify composer:v1 in tools to use prestissimo
|
|
Cache composer packages
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Loading