-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADS-4220 Add support for search requests #357
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to dump the whole GraphQL response in the objects here?
Please review what you can re-use and what will actually be used from the responses.
You already have Types/Product, and I'm not sure why would you need the whole Hit/
namespace.
I just think it makes sense to move everything to the classes, because then you have autocompletion when trying to access it. If it's just one big
You mean, like
Did not see this type files before. But some points:
|
Description
https://nostosolutions.atlassian.net/browse/ADS-4193
https://nostosolutions.atlassian.net/browse/ADS-4194
Related Issue
Motivation and Context
How Has This Been Tested?
Documentation:
Checklist: